Tor Browser with meek opens two Software Update windows

When I'm browsing with meek, I tend to get two "Software Update Available" windows appearing simultaneously. I suppose the second one is from the headless meek-http-helper.

added TorBrowserTeam201502 component::circumvention/meek owner::dcf priority::medium resolution::fixed status::closed type::defect labels

It looks like we can turn off updating in the headless browser by setting the pref app.update.enabled=false. https://developer.mozilla.org/en-US/docs/Mozilla/Projects/XULRunner/Application_Update I'll try that and see if it works.

Trac:
0001-Disable-software-update-windows-in-the-meek-HTTP-hel.patch

0001-Disable-software-update-windows-in-the-meek-HTTP-hel.patch​ sets app.update.enabled=false. I tested it by manually setting the setting in the user.js of 4.0.2, and seeing that only one software update window appeared.

Trac:
Keywords: N/A deleted, TorBrowserTeam201502 added
Status: new to needs_review

The patch looks good. Two questions:

1. Do you have commit access to builders/tor-browser-bundle.git ?
2. Do you we want this fix in 4.0.x or just in 4.5 ? (or maybe I should ask mikeperry).

Trac:
Cc: N/A to brade, mcs

Trac:
Keywords: TorBrowserTeam201502 deleted, TorBrowserTeam201502R added

Replying to mcs:

The patch looks good. Two questions:

1. Do you have commit access to builders/tor-browser-bundle.git ?

No, but I kind of prefer not to have. I'm fine with asking for patches to be merged.

2. Do you we want this fix in 4.0.x or just in 4.5 ? (or maybe I should ask mikeperry).

I don't care. I'm not aware of any user complaints about the two update windows, so it's fine if you want to try it in an alpha first.

I am concerned that accepting the meek version of the update notice will cause surprise issues, perhaps even leading to a damaged TBB directory. This is making me think we should take this change for both the stable and the alpha TBB.

Replying to mikeperry:

I am concerned that accepting the meek version of the update notice will cause surprise issues, perhaps even leading to a damaged TBB directory. This is making me think we should take this change for both the stable and the alpha TBB.

Good point. At best, untested. At worst, completely broken. Certainly confusing. So I agree with you.

Ok, pushed to maint-4.0 and master, for 4.0 and 4.5. Thanks, David!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed
Keywords: TorBrowserTeam201502R deleted, TorBrowserTeam201502 added

closed

mentioned in issue #15523 (moved)

mentioned in issue #29611 (moved)

moved to tpo/anti-censorship/pluggable-transports/meek#14203 (closed)

mentioned in issue tpo/applications/tor-browser#29611 (closed)