Opened 3 years ago

Closed 3 years ago

#14203 closed defect (fixed)

Tor Browser with meek opens two Software Update windows

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Obfuscation/meek Version:
Severity: Keywords: TorBrowserTeam201502
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I'm browsing with meek, I tend to get two "Software Update Available" windows appearing simultaneously. I suppose the second one is from the headless meek-http-helper.

Child Tickets

Attachments (1)

0001-Disable-software-update-windows-in-the-meek-HTTP-hel.patch (1.2 KB) - added by dcf 3 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 3 years ago by dcf

It looks like we can turn off updating in the headless browser by setting the pref app.update.enabled=false.
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/XULRunner/Application_Update
I'll try that and see if it works.

comment:2 Changed 3 years ago by dcf

Keywords: TorBrowserTeam201502 added
Status: newneeds_review

attachment:0001-Disable-software-update-windows-in-the-meek-HTTP-hel.patch​ sets app.update.enabled=false. I tested it by manually setting the setting in the user.js of 4.0.2, and seeing that only one software update window appeared.

comment:3 Changed 3 years ago by mcs

Cc: brade mcs added

The patch looks good. Two questions:

  1. Do you have commit access to builders/tor-browser-bundle.git ?
  2. Do you we want this fix in 4.0.x or just in 4.5 ? (or maybe I should ask mikeperry).

comment:4 Changed 3 years ago by mikeperry

Keywords: TorBrowserTeam201502R added; TorBrowserTeam201502 removed

comment:5 in reply to:  3 Changed 3 years ago by dcf

Replying to mcs:

The patch looks good. Two questions:

  1. Do you have commit access to builders/tor-browser-bundle.git ?

No, but I kind of prefer not to have. I'm fine with asking for patches to be merged.

  1. Do you we want this fix in 4.0.x or just in 4.5 ? (or maybe I should ask mikeperry).

I don't care. I'm not aware of any user complaints about the two update windows, so it's fine if you want to try it in an alpha first.

comment:6 Changed 3 years ago by mikeperry

I am concerned that accepting the meek version of the update notice will cause surprise issues, perhaps even leading to a damaged TBB directory. This is making me think we should take this change for both the stable and the alpha TBB.

comment:7 in reply to:  6 Changed 3 years ago by mcs

Replying to mikeperry:

I am concerned that accepting the meek version of the update notice will cause surprise issues, perhaps even leading to a damaged TBB directory. This is making me think we should take this change for both the stable and the alpha TBB.

Good point. At best, untested. At worst, completely broken. Certainly confusing. So I agree with you.

comment:8 Changed 3 years ago by mikeperry

Keywords: TorBrowserTeam201502 added; TorBrowserTeam201502R removed
Resolution: fixed
Status: needs_reviewclosed

Ok, pushed to maint-4.0 and master, for 4.0 and 4.5. Thanks, David!

Note: See TracTickets for help on using tickets.