Opened 5 years ago

Closed 5 years ago

#14221 closed defect (fixed)

mkbundle-*.sh does not update correctly the $TORBROWSER_VERSION -> $TORBROWSER_BUILDDIR symlink at the end of the build

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201502R, MikePerry201502R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

At the end of a build, mkbundle-*.sh should update a symlink $TORBROWSER_VERSION -> $TORBROWSER_BUILDDIR.

If the symlink already exists it does not update it correctly. This is because the ln command is missing a -T option.

I'm attaching a patch to fix that.

Child Tickets

Attachments (2)

Change History (12)

comment:1 Changed 5 years ago by gk

I wonder whether it would be smarter to leave the link complexity out and just take the TORBROWSER_VERSION as build dir in case there is a tag at least. Assuming we really tag an official build from now on before starting it that should lead to the behavior we had up to and including the previous alpha release. (sorry that I did not have the idea earlier while reviewing your code, in case it is not a stupid one, of course ;) )

comment:2 Changed 5 years ago by gk

Status: newneeds_information

To add another thought: this would avoid the need for renaming the directory in our current release flow (see e.g. the 4.5a3-build2 dir in Mike's build directory which should be just 4.5a3).

comment:3 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201502R added; TorBrowserTeam201501R removed

comment:4 in reply to:  2 Changed 5 years ago by boklm

Replying to gk:

To add another thought: this would avoid the need for renaming the directory in our current release flow (see e.g. the 4.5a3-build2 dir in Mike's build directory which should be just 4.5a3).

Renaming the build directory on people.tpo ?

It's also possible to keep it as "4.5a3-build2" on people.tpo, which allows to see which tag was used to build it.

But if having the build number in the directory name is not so useful, then yes it's probably better to remove the symlink and not include the build number in the directory name.

comment:5 Changed 5 years ago by gk

Keywords: GeorgKoppen201502R added

comment:6 Changed 5 years ago by mikeperry

It's my thinking that keeping the build number in the dest directory and on people.torproject.org will be useful for testing, but that for the dir on dist.torproject.org, we should not include the build portion.

This may complicate our release process though, but I *think* the net gain from being more clear about what build was actually tested by the automated testing will be a win?

comment:7 Changed 5 years ago by gk

I am not convinced. But I don't feel like digging up a huge amount of data backing my reasoning + doing some extrapolation about our future release quality at the moment. I can live with having a release and build process that is definitely more complex if we gain probably easier to understand testing results. :)

comment:8 Changed 5 years ago by gk

Keywords: MikePerry201502R added; GeorgKoppen201502R removed
Status: needs_informationneeds_review

Commit b90119dd4194209af8168997eeb3181490d609ba has the fix and attached is the patch for the release process.

comment:9 Changed 5 years ago by boklm

The release process patch looks good.

comment:10 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Ok, I updated that release process patch to use the builddir vars in more places, and generally tried to clean it up to reflect our new tag-based release process. Sadly this means it won't work with cut-and-paste for our 4.0 releases, but the 4.5 releases should be smoother now as a result.

Note: See TracTickets for help on using tickets.