Opened 5 years ago

Last modified 2 years ago

#14266 new defect

Make address mapping conditional on having the particular address mapping types enabled.

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client refactoring
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It might be simpler to understanding the logic for address mapping if each type of mapping were conditional on having the right thing enabled. For example:

  • DNS mapping could be conditional on client-side DNS caching (bad idea!) being enabled.
  • Automap mapping could be conditional on AutomapHostsOnResolve being enabled.
  • TrackExit mapping could be conditional on having TrackHostExits being set.
  • MapAddress mappings could be applied only if MapAddress is set.
  • MAPADDRESS mappigns could be applied only if the controller MAPADDRESS command has called.

Would this make the logic more clear?

Child Tickets

Change History (1)

comment:1 Changed 2 years ago by nickm

Priority: MediumLow
Severity: Normal
Note: See TracTickets for help on using tickets.