Investigate missing Tor Browser patches to make Unix Domain Socket option work

In: https://bugzilla.mozilla.org/show_bug.cgi?id=892114 Mozilla implemented support for AF_UNIX sockets. We should look at the patch and estimate whether we need something more to implement support for it into Tor Browser.

added TorBrowserTeam201608R component::applications/tor browser owner::mikeperry parent::14270 priority::high resolution::fixed severity::normal sponsor::U status::closed tbb-security type::task labels

Trac:
Summary: Investigate missing Tor Browser patches to make SocksSocket option work to Investigate missing Tor Browser patches to make Unix Domain Socket option work

Trac:
Owner: gk to mikeperry
Status: new to assigned

Trac:
Cc: N/A to brade, mcs

Trac:
Cc: brade, mcs to brade, mcs, whonix-devel@whonix.org

Related Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1211567

Trac:
Sponsor: N/A to N/A

Trac:
Cc: brade, mcs, whonix-devel@whonix.org to brade, mcs, whonix-devel@whonix.org, arthuredelstein

Trac:
Priority: Medium to High
Sponsor: N/A to SponsorU

Getting important SponsorU things on our August radar.

Trac:
Keywords: N/A deleted, TorBrowserTeam201608 added

mcs/brade: Do you think you could look into whether we could just backport the relevant patches to ESR 45 (as far as I can see only the one in 1211567 is relevant, but maybe I am missing something)? That way we could get all the things for unix domain sockets landed for the next alpha and could start experimenting for realz.

Trac:
Severity: N/A to Normal
Reviewer: N/A to N/A

Replying to gk:

mcs/brade: Do you think you could look into whether we could just backport the relevant patches to ESR 45 (as far as I can see only the one in 1211567 is relevant, but maybe I am missing something)? That way we could get all the things for unix domain sockets landed for the next alpha and could start experimenting for realz.

Eventually we will want UI fixes as well (https://bugzilla.mozilla.org/show_bug.cgi?id=1294611) but backporting 1211567 seems to be sufficient to make things work on OSX (and presumably Linux as well).

In fact, we already backported this in order to test our #19733 (moved) patch. If I remember correctly, we did not need to make any changes to the patch. Here it is: https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=mozbug1211567-02&id=797ee78de0992d98e0a1239177bbb456dd3ec1e8

Yes, as soon as the UI fixes are made they are a good candidate for cherry-picking.

Trac:
Keywords: TorBrowserTeam201608 deleted, TorBrowserTeam201608R added
Status: assigned to needs_review

Thinking about this some more, for the alpha I assume we want to use Unix domain sockets by default on Linux and OSX. That means we should change torrc-defaults to use a path for SocksPort and ControlPort. And then we will need to change the browser's network.proxy.socks pref value to match the SocksPort value. The pref value needs to be a file: URL and of course the SocksPort and ControlPort directives need to look like unix:/path/to/socket.

Do you want Kathy and me to create appropriate patches for tor-browser and builders/tor-browser-bundle?

Replying to mcs:

Thinking about this some more, for the alpha I assume we want to use Unix domain sockets by default on Linux and OSX. That means we should change torrc-defaults to use a path for SocksPort and ControlPort. And then we will need to change the browser's network.proxy.socks pref value to match the SocksPort value. The pref value needs to be a file: URL and of course the SocksPort and ControlPort directives need to look like unix:/path/to/socket.

Do you want Kathy and me to create appropriate patches for tor-browser and builders/tor-browser-bundle?

That would be neat. You could use #14270 (moved) for that or create a new child ticket of it for this task I guess.

FWIW the rebased Mozilla patch looks good to me. It is applied on tor-browser-45.3.0esr-6.5-1 (commit cde73b2295b75898ca435ed9f78541eccf6c34cb).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Replying to gk:

Do you want Kathy and me to create appropriate patches for tor-browser and builders/tor-browser-bundle?

That would be neat. You could use #14270 (moved) for that or create a new child ticket of it for this task I guess.

I created a new ticket because we need to discuss some design issues: #20111 (moved).

closed

moved to tpo/applications/tor-browser#14273 (closed)