Opened 5 years ago

Closed 5 years ago

#14282 closed defect (fixed)

tutorial_examples.py fixup for Python26 and Python34

Reported by: Foxboron Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I was a little bit stupid while testing the last patch. Turns out you had to have the
ordereddict where i removed it previously.
My mistake.

Turns out python26 does not have the assertListEqual, and Python27 failed on it for
unknown reasons. The fix is basically to split the list and sort them. Ensured equal order
on python26-python27.
Again, my mistake. Should have fixed this, but i didn't check with tox.

With this patch, "everything" (Python31 is still untested on my part) is now passing using
the tox branch!
Thats some good news atleast :)

  py26: commands succeeded
  py27: commands succeeded
ERROR:   py31: InterpreterNotFound: python3.1
  py32: commands succeeded
  py33: commands succeeded
  py34: commands succeeded

Commit:
https://github.com/Foxboron/stem/commit/55f2d11e164de56f749f913e57de812153c70550

Child Tickets

Change History (1)

comment:1 Changed 5 years ago by atagar

Resolution: fixed
Status: newclosed

Thanks! Merged.

Note: See TracTickets for help on using tickets.