Opened 3 years ago

Closed 11 months ago

#14328 closed enhancement (fixed)

only one syntax for Exit Policy Summaries

Reported by: cholin Owned by: phw
Priority: Very Low Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If you configure a tor relay and look for your your node in atlas you can notice different exit policy summary syntaxes for ipv4 and ipv6. "Exitpolicy reject *:*" in your torrc gets displayed as "reject 1-65535" for ipv4 and "reject *:*" for ipv6. This may confuse people. I think it's better to have only one equivalent syntax for a semantic. Therefor either *:* or 1-65535 and not both.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by phw

Status: newneeds_information

Do you have an example? And is it possible that you are confusing the exit policy with the exit policy summary?

comment:2 Changed 3 years ago by cholin

Well your right. As there is no space between "IPv6 Exit Policy Summary" and "Exit Policy" I assumed the pre text belongs to "IPv6 Exit Policy Summary". Maybe to prevent such misinterpretation you could show as well a pre-tag with like 'no ipv6' for IPv6 Exit Policy Summary"

comment:3 in reply to:  2 Changed 3 years ago by phw

Replying to cholin:

Well your right. As there is no space between "IPv6 Exit Policy Summary" and "Exit Policy" I assumed the pre text belongs to "IPv6 Exit Policy Summary". Maybe to prevent such misinterpretation you could show as well a pre-tag with like 'no ipv6' for IPv6 Exit Policy Summary"

Sounds reasonable. I committed a fix to the following git branch: https://gitweb.torproject.org/user/phw/atlas.git/commit/?h=bug_14328

If there are no objections, I will merge it to master in a couple of days.

comment:4 Changed 3 years ago by karsten

LGTM!

comment:5 Changed 11 months ago by karsten

Severity: Normal
Status: needs_informationneeds_review

Looks like this patch was never merged and that phw's bug_14328 branch does not exist anymore. Good thing I still had a local copy of that branch around. Please review commit f4f5a5b in my task-14328 branch, cherry-pick, and merge if it looks good.

comment:6 Changed 11 months ago by irl

Resolution: fixed
Status: needs_reviewclosed

Merged, thanks. (:

Note: See TracTickets for help on using tickets.