Opened 4 years ago

Closed 12 months ago

#14355 closed task (wontfix)

SimpleHTTPChannel for HTTP test helpers should be generalised

Reported by: irl Owned by:
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Normal Keywords: oonib_test_helpers, archived-closed-2018-07-04
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently SimpleHTTPChannel in http_helpers.py implements the http-return-json-headers test helper directly. As this test helper runs on port 80, the SimpleHTTP channel protocol should be generalised to allow for using the request line as a selector for other tests.

No existing implemented tests in ooni-probe request a resource other than the root resource ("/") and so the use of a selector will not mean changes are required to the implementation of those tests and this is also compatible with the specification of the http-return-json-headers helper.

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by irl

Status: newaccepted

As this change will be necessary in order to implement the TCP scapy test helpers, I will look at making these modifications while implementing the TCP scapy test helpers.

comment:2 Changed 4 years ago by irl

Keywords: oonib_test_helpers added

comment:3 Changed 3 years ago by irl

Severity: Normal
Status: acceptednew

I'm afraid I no longer have the time available for doing the layer 4 reachability tests, so I won't be able to take care of this. I'll set the status back to new and perhaps someone else will accept it.

comment:4 Changed 3 years ago by irl

Owner: irl deleted
Status: newassigned

comment:5 Changed 3 years ago by irl

Status: assignednew

comment:6 Changed 12 months ago by teor

Keywords: archived-closed-2018-07-04 added
Resolution: wontfix
Status: newclosed

Close all tickets in archived components

Note: See TracTickets for help on using tickets.