Opened 4 years ago

Closed 4 years ago

Last modified 7 months ago

#14392 closed defect (fixed)

about:tor should behave more like about:newtab

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-pref, tbb-usability, TorBrowserTeam201502, MikePerry201502, tbb-no-uplift
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should set browser.newtab.url to about:tor instead of about:newtab for consistency.

Child Tickets

Change History (12)

comment:1 Changed 4 years ago by mikeperry

Turns out this has some annoying side effects. Namely, the cursor focus on the new tab is the startpage search bar now instead of the url bar, so this is not quite as simple as setting the pref. I wonder if we can make about:tor behave like about:newtab in that it clears the URL bar and makes it the focus rather than the search box.

comment:2 in reply to:  1 Changed 4 years ago by saint

Replying to mikeperry:

the cursor focus on the new tab is the startpage search bar

The about:tor page also uses javascript -- the jquery on this page also sets the .focus onto the startpage input box. Deleting line 34 of src/chrome/content/aboutTor/aboutTor.xhtml will solve the focus issue. This is all legacy torbutton code from early 2013 (commit c48bf013150c6a5cd0bfc17cf219615824208f44).

Last edited 4 years ago by saint (previous) (diff)

comment:3 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201502 added; TorBrowserTeam201501 removed

comment:4 Changed 4 years ago by mikeperry

Keywords: MikePerry201502 added

comment:5 Changed 4 years ago by mikeperry

Owner: changed from tbb-team to mikeperry
Status: newassigned

comment:6 Changed 4 years ago by mcs

Cc: brade mcs added

Mike, let me know if you want Kathy and me to dig deeper to see if we can get behavior closer to that of about:newtab.

comment:7 Changed 4 years ago by mcs

On IRC, Mike suggested that due to shoulder surfing concerns, we may not want to make about:tor the default new tab page after all. But we should make it work better in case someone chooses to set browser.newtab.url = about:tor.

For focus, we may be able to make the search box focus conditional so that home page behavior is different than new tab behavior.

For the URL bar, we need to figure out how pages like about:newtab and about:blank and handled. The solution may be as simple as adding about:tor to the gInitialPages array inside browser/base/content/browser.js (that requires a core browser patch though).

comment:8 Changed 4 years ago by mikeperry

Summary: about:tor should be the default new tab pageabout:tor should behave more like about:newtab

comment:9 Changed 4 years ago by mikeperry

Resolution: fixed
Status: assignedclosed

Ok, I added about:tor to the gInitialPages array in browser/base/content/browser.js, and that did in fact do the trick. I also removed the focus grabbing code as suggested by saint.

These changes should appear in 4.5a4.

comment:10 Changed 7 months ago by arthuredelstein

Keywords: tbb-dont-uplift added
Severity: Blocker

comment:11 Changed 7 months ago by arthuredelstein

Severity: BlockerNormal

comment:12 Changed 7 months ago by arthuredelstein

Keywords: tbb-no-uplift added; tbb-dont-uplift removed
Note: See TracTickets for help on using tickets.