Opened 5 years ago

Closed 5 years ago

#14420 closed defect (fixed)

Simplify fetch-inputs.sh to remove old auth cruft

Reported by: mikeperry Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-gitian, TorBrowserTeam201501R
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We have some old cruft in fetch-inputs.sh from before we stored SHA256SUMs for everything in our repos. There is some double-downloading code, as well as the use of a mirror URL for OpenSSL when we didn't need to do so.

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by mikeperry

Cc: gk added
Status: newneeds_review

See mikeperry/bug14420-4.0 and mikeperry/bug14420-master.

comment:2 Changed 5 years ago by gk

Adding OPENSSL to the for loop in verify-tags.sh as well seems to be missing. I can do that in a follow-up commit if you don't want to "fix" that with a new branch. Otherwise looks good.

comment:3 in reply to:  2 Changed 5 years ago by mikeperry

Replying to gk:

Adding OPENSSL to the for loop in verify-tags.sh as well seems to be missing. I can do that in a follow-up commit if you don't want to "fix" that with a new branch. Otherwise looks good.

Ok, this should be fixed too. Thanks.

comment:4 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Merged into master (9a8c0663abb0359b743865bca24b22316bb16fac and e64e8d53b511525671d83d6d3631f82388b5e7bc) and maint-4.0 (d4cfa02d22cefb43a5b66e6f0d10a876a78a3b33 and 7082e1ff92942409eea40a7d19b5bba25a9a0272).

Note: See TracTickets for help on using tickets.