Changes between Initial Version and Version 1 of Ticket #14429, comment 17


Ignore:
Timestamp:
Feb 13, 2015, 6:50:00 AM (5 years ago)
Author:
arthuredelstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #14429, comment 17

    initial v1  
    22> What made you pick 1000ms? If we set this to 100ms or even 10ms, will there be issues on some systems? I will play with some timeouts on my systems and see if I notice anything, but I was curious if you had a reason for picking such a large delay.
    33
    4 That's a good point. While the user is resizing the window (by dragging an edge or corner), the chrome window object fires many "resize" events. I couldn't find any nice way to detect if the user has stopped dragging the window (mousedown/up events don't fire), so I decided just to wait until it we feel it is safe to assume that the user has finished dragging before calling `shrinkwrap()`. I'm not sure what this time is, but 250 ms seemed too short, at least with myself as the test subject. I think 500 ms seems OK. (If the user does pause in a drag, then the shrinkwrap occurs anyway, even though the mouse is still in "dragging" mode.) Let me know what you think.
     4That's a good point. While the user is resizing the window (by dragging an edge or corner), the chrome window object fires many "resize" events. I couldn't find any nice way to detect if the user has stopped dragging the window (mousedown/up events don't fire), so I decided just to wait until we feel it is safe to assume that the user has finished dragging before calling `shrinkwrap()`. I'm not sure what this time is, but 250 ms seemed too short, at least with myself as the test subject. I think 500 ms seems OK. (If the user does pause in a drag, then the shrinkwrap occurs anyway, even though the mouse is still in "dragging" mode.) Let me know what you think.
    55
    66I just measured the typical time interval between "resize" events and the interval is almost always 50 ms or less, except if I leave the mouse down and stop moving for a while. (This may be unusually easy for me because I am testing with a touchpad where a double-tap leaves the mouse down.)