Make Disconnect Search the default search engine for Tor Browser alpha

We want to make Disconnect Search the default engine for Tor Browser alpha. I guess the second choice would then be Startpage and the third DuckDuckGo.

added MikePerry201502R TorBrowserTeam201502R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed status::closed type::enhancement labels

Mike: Are you still working on a generic Disconnect plugin that could change the search locale depending on the Tor Browser locale? If not, how should we proceed? Should we ask Disconnect instead or should I put it on my plate?

Trac:
Status: new to needs_information

Trac:
Keywords: TorBrowserTeam201501 deleted, TorBrowserTeam201502 added

Trac:
disconnect_search_spec.xml

After finding https://bugzilla.mozilla.org/show_bug.cgi?id=670451, I experimented using {moz:locale} to insert the locale, but this did not seem to work. We would also want this to be tied to our spoof_english pref, as that bugzilla bug rightly points out that this is a privacy leak.

I will review this, #14318 (moved), and #11236 (moved).

Trac:
Keywords: TorBrowserTeam201502 deleted, MikePerry201502R, TorBrowserTeam201502R added

Trac:
Status: needs_information to needs_review

Ok, I pushed the disconnect.xml to tor-browser.git and generally cleaned up the omnibox. I also updated about:tor in torbutton.

This change will appear in 4.5a4. We may want to keep these commits on the alpha series only, depending on how the trial goes.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Replying to mikeperry:

Ok, I pushed the disconnect.xml to tor-browser.git and generally cleaned up the omnibox. I also updated about:tor in torbutton.

What speaks against "Disconnect Search" as the search engine's short name (which the attached .xml contains)? Just having "Search" may not be so meaningful to users not knowing the Disconnect logo.

Concerns about this change have been expressed in https://blog.torproject.org/blog/tor-browser-451-released comments and in the tor-talk thread "Invaded by disconnect.me". Given that the disconnect search plug-in apparently isn't installed, there arguably aren't serious anonymity issues. But there has been no "official" comment from the Tor Project that I know of. That would be helpful, I think.

Trac:
Username: mirimir

closed

moved to tpo/applications/tor-browser#14490 (closed)