Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#14490 closed enhancement (fixed)

Make Disconnect Search the default search engine for Tor Browser alpha

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201502R, MikePerry201502R
Cc: mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We want to make Disconnect Search the default engine for Tor Browser alpha. I guess the second choice would then be Startpage and the third DuckDuckGo.

Child Tickets

Attachments (1)

disconnect_search_spec.xml (2.1 KB) - added by gk 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by gk

Status: newneeds_information

Mike: Are you still working on a generic Disconnect plugin that could change the search locale depending on the Tor Browser locale? If not, how should we proceed? Should we ask Disconnect instead or should I put it on my plate?

comment:2 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201502 added; TorBrowserTeam201501 removed

Changed 4 years ago by gk

Attachment: disconnect_search_spec.xml added

comment:3 Changed 4 years ago by mikeperry

After finding https://bugzilla.mozilla.org/show_bug.cgi?id=670451, I experimented using {moz:locale} to insert the locale, but this did not seem to work. We would also want this to be tied to our spoof_english pref, as that bugzilla bug rightly points out that this is a privacy leak.

comment:4 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201502R MikePerry201502R added; TorBrowserTeam201502 removed

I will review this, #14318, and #11236.

comment:5 Changed 4 years ago by mikeperry

Status: needs_informationneeds_review

comment:6 Changed 4 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Ok, I pushed the disconnect.xml to tor-browser.git and generally cleaned up the omnibox. I also updated about:tor in torbutton.

This change will appear in 4.5a4. We may want to keep these commits on the alpha series only, depending on how the trial goes.

comment:7 in reply to:  6 Changed 4 years ago by gk

Replying to mikeperry:

Ok, I pushed the disconnect.xml to tor-browser.git and generally cleaned up the omnibox. I also updated about:tor in torbutton.

What speaks against "Disconnect Search" as the search engine's short name (which the attached .xml contains)? Just having "Search" may not be so meaningful to users not knowing the Disconnect logo.

comment:8 Changed 3 years ago by mirimir

Concerns about this change have been expressed in https://blog.torproject.org/blog/tor-browser-451-released comments and in the tor-talk thread "Invaded by disconnect.me". Given that the disconnect search plug-in apparently isn't installed, there arguably aren't serious anonymity issues. But there has been no "official" comment from the Tor Project that I know of. That would be helpful, I think.

Note: See TracTickets for help on using tickets.