Opened 5 years ago

Last modified 3 years ago

#14556 new enhancement

Add basic I/O syscall wrappers

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay not-sure-if-good-idea
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is to have more safer I/O operations such as read(), write(), send(), recv() that can handle partial read/write and EINTR. They can also handle the size overflow and correctly handle errno.

Flagging this 0.2.6.x-final because #14554 depends on that to be fixed correctly.

Branch should be coming shortly.

Child Tickets

Change History (13)

comment:1 Changed 5 years ago by dgoulet

Status: newneeds_review

Here it is. Working perfectly fine with chutney. There are also tests for read/write.

Branch bug14556_026_v1

This one needs to be merged before we can fix #14554 using those wrappers.

comment:2 Changed 5 years ago by dgoulet

Milestone: Tor: 0.2.6.x-finalTor: 0.2.7.x-final
Status: needs_reviewnew

Ok, #14554 has now a fix without this branch which is fine for now. We'll send back a new branch once we fix it with the use of these wrappers.

Too close from 0.2.6 release so postpone this one since it's a patch on some low level I/O ops.

comment:3 Changed 5 years ago by nickm

Status: newassigned

comment:4 Changed 5 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:5 Changed 5 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:8 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:9 Changed 3 years ago by nickm

Keywords: 027-triaged-in added

comment:10 Changed 3 years ago by nickm

Keywords: 027-triaged-in removed

comment:11 Changed 3 years ago by nickm

Keywords: 027-triaged-1-out removed

comment:12 Changed 3 years ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:13 Changed 3 years ago by nickm

Keywords: tor-relay not-sure-if-good-idea added
Severity: Normal

dgoulet, is this still something we should plan to do?

Note: See TracTickets for help on using tickets.