Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#14630 closed defect (fixed)

Remove "TorButton > Preferences > Proxy Settings" Tab

Reported by: arthuredelstein Owned by: mikeperry
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability uxsprint2015, MikePerry201502, TorBrowserTeam201502
Cc: gk, brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

As far as I understand, this tab is redundant or mostly redundant. One of the UX test users was confused by it. For example, I'm confident nobody is using Gopher or FTP settings. It would be nice to remove the entire tab, if possible. If there are any features or options still needed, we could move them to the "Torbutton > Open Network Settings" window.

Child Tickets

TicketStatusOwnerSummaryComponent
#14629closedtbb-teamTorbutton prefs are confusing and unnecessaryApplications/Tor Browser
#14635closedtbb-teamTransparent Torification test button complains about PolipoApplications/Tor Browser

Change History (11)

comment:1 Changed 4 years ago by gk

Cc: gk added

comment:2 Changed 4 years ago by mcs

Cc: brade mcs added

comment:3 Changed 4 years ago by mikeperry

Keywords: MikePerry201502 TorBrowserTeam201502 added

comment:4 Changed 4 years ago by mikeperry

Owner: changed from tbb-team to mikeperry
Status: newassigned

comment:5 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201502R added; TorBrowserTeam201502 removed
Status: assignedneeds_review

comment:6 Changed 4 years ago by mikeperry

I dupped #11191 to this bug.

comment:7 Changed 4 years ago by mcs

Kathy and I reviewed (and ran) these changes. Everything looks good to us.

comment:8 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201502 added; TorBrowserTeam201502R removed
Resolution: fixed
Status: needs_reviewclosed

Ok, merged. Thanks!

comment:9 Changed 4 years ago by cypherpunks

Keywords !TorBrowserTeam201502 !MikePerry201502 added
I think removing this UI pane from Torbutton entirely is the right move. Users who need to set proxy settings can do this via the Firefox settings, which still work just fine.

Unfortunately, this does not "still work just fine" in TBB 4.5.

The proxy configuration (e.g. piping a system-wide tor instance through Privoxy) via the Firefox settings fails, unless I disable Torbutton completely (which I would never want to).
The settings dialog even points out that Torbutton needs to be disabled for those network settings to work.

Why can't I enable Torbutton and use custom proxy settings anymore?

comment:10 Changed 4 years ago by mikeperry

Ugh. You are right. I filed #15852 to make this slightly better. For now, you need to either edit the Torbutton about:config prefs 'extensions.torbutton.socks_host' and 'extensions.torbutton.socks_port', or set the environment variables TOR_SOCKS_HOST and TOR_SOCKS_PORT before starting TBB.

comment:11 Changed 4 years ago by mikeperry

Also filed #15853 to document how to run multiple TBB instances concurrently, or just run it with an alternate Tor instance.

Note: See TracTickets for help on using tickets.