Disable Cookie Manager until we get it working
Right now the Cookie Manager doesn't work, and it's pretty confusing. I would propose hiding it from the Torbutton menu until it's ready.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
Trac:
Cc: N/A to gk
Keywords: tbb-usability uxsprint2015 deleted, tbb-usability, uxsprint2015, tbb-torbutton addedTrac:
Keywords: N/A deleted, TorBrowserTeam201502, MikePerry201502 addedTrac:
Owner: tbb-team to mikeperry
Status: new to assignedGood news that you'll be working on it! I could not find a ticket about actually fixing the Cookie Manager, though. That problem seems to be related to:
Trac:
Cc: gk to gk, bastik.public@gmx-topmail.deTrac:
Username: michael
Cc: gk, bastik.public@gmx-topmail.de to gk, bastik.public@gmx-topmail.de, michaelThis should be fixed in my 1.8-next branch: https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=1.8-next&id=31d27508964eeb4594cc9dea678ae5f243b1f63f
Please review?
Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201502 deleted, TorBrowserTeam201502R added- Author
Replying to mikeperry:
This should be fixed in my 1.8-next branch: https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=1.8-next&id=31d27508964eeb4594cc9dea678ae5f243b1f63f
Please review?
I tested it and examined the code and it looks fine. I might suggest adding a reference to #10353 (moved) in the comment:
// XXX: Bug 14632: The cookie dialog is useless in private browsing mode in FF31ESR :(
Updated the comment and pushed this. Thanks!
Trac:
Keywords: TorBrowserTeam201502R deleted, TorBrowserTeam201502 added
Resolution: N/A to fixed
Status: needs_review to closed- Trac closed
closed
- Mike Perry mentioned in issue #15334 (moved)
mentioned in issue #15334 (moved)
- Trac mentioned in issue tpo/applications/tor-browser#15334 (closed)
mentioned in issue tpo/applications/tor-browser#15334 (closed)