Opened 5 years ago

Closed 5 years ago

#14632 closed defect (fixed)

Disable Cookie Manager until we get it working

Reported by: arthuredelstein Owned by: mikeperry
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability, tbb-torbutton, uxsprint2015, MikePerry201502, TorBrowserTeam201502
Cc: gk, bastik.public@…, michael Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Right now the Cookie Manager doesn't work, and it's pretty confusing. I would propose hiding it from the Torbutton menu until it's ready.

Child Tickets

Change History (9)

comment:1 Changed 5 years ago by gk

Cc: gk added
Keywords: tbb-torbutton added

comment:2 Changed 5 years ago by mikeperry

Keywords: MikePerry201502 TorBrowserTeam201502 added

comment:3 Changed 5 years ago by mikeperry

Owner: changed from tbb-team to mikeperry
Status: newassigned

comment:4 Changed 5 years ago by intrigeri

Good news that you'll be working on it! I could not find a ticket about actually fixing the Cookie Manager, though. That problem seems to be related to:

comment:5 Changed 5 years ago by bastik

Cc: bastik.public@… added

comment:6 Changed 5 years ago by michael

Cc: michael added

comment:7 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201502R added; TorBrowserTeam201502 removed
Status: assignedneeds_review

comment:8 in reply to:  7 Changed 5 years ago by arthuredelstein

Replying to mikeperry:

This should be fixed in my 1.8-next branch: https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=1.8-next&id=31d27508964eeb4594cc9dea678ae5f243b1f63f

Please review?

I tested it and examined the code and it looks fine. I might suggest adding a reference to #10353 in the comment:

// XXX: Bug 14632: The cookie dialog is useless in private browsing mode in FF31ESR :(

comment:9 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201502 added; TorBrowserTeam201502R removed
Resolution: fixed
Status: needs_reviewclosed

Updated the comment and pushed this. Thanks!

Note: See TracTickets for help on using tickets.