Opened 5 years ago

Closed 5 years ago

#14741 closed defect (fixed)

Cancelling a cpuworker job doesn't decrement the total pending tasks counter

Reported by: dgoulet Owned by:
Priority: Immediate Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.6.2-alpha
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

cpuworker_cancel_circ_handshake() should decrement the total_pending_tasks counter if the job was successfully cancelled meaning "job" if not NULL.

This issue has been observed with a fast relay where enough jobs were cancelled making if (total_pending_tasks >= max_pending_tasks) always true. There are no ways to decrement the counter without having a worker actually completing a job that now can't be queued because we've reached the maximum task allowed.

This makes the relay stop working correctly since no onionskin job can be achieved anymore.

Child Tickets

Change History (1)

comment:1 Changed 5 years ago by nickm

Keywords: tor-relay added
Priority: criticalblocker
Resolution: fixed
Status: newclosed

2274221 should fix this. Thanks!

Note: See TracTickets for help on using tickets.