Opened 5 years ago

Closed 4 years ago

#14806 closed enhancement (implemented)

Drop test_cmdline_args.py

Reported by: atagar Owned by:
Priority: Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Before a couple weeks ago didn't know Tor had these tests, interesting! Stem already has tests for spawning tor processes but lacked any with this targeted focus on its arguments.

I've added our own counterpart for these tests. Many are direct copies but there were others I improved a little...

https://trac.torproject.org/projects/tor/ticket/14109
https://gitweb.torproject.org/stem.git/commit/?id=137d193a026638f066e817e3396cebbbb6ace012

Now that Tor uses Stem to supplement its tests no reason for these to live separately. Tested by simply building tor and confirming test_cmdline_args.py is no longer in the generated Makefile.

Patch will be uploaded in a sec...

Child Tickets

Change History (7)

comment:1 Changed 5 years ago by Sebastian

Milestone: Tor: 0.2.7.x-final

comment:3 Changed 5 years ago by atagar

Status: newneeds_review

comment:4 Changed 5 years ago by Sebastian

The code changes lgtm, but you need a changes file for this.

comment:6 Changed 5 years ago by nickm

Fine by me! Let's take this once 0.2.7 is open.

comment:7 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

merged!

Note: See TracTickets for help on using tickets.