Opened 5 years ago

Last modified 2 years ago

#14827 new defect

Tor controller command to write its file to disk

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords: tor-client tor-control needs-design
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

atagar wants that for the tests.

Child Tickets

Change History (26)

comment:1 Changed 5 years ago by atagar

Thanks Sebastian. I'll try to provide an update on Wednesday or Thursday with the details of what the tests look for and why.

comment:2 Changed 5 years ago by nickm

What does "write its file to disk" mean in this context? What file are we talking about here?

comment:3 Changed 5 years ago by Sebastian

Descriptors, state file

comment:4 Changed 5 years ago by atagar

Hi Sebastian, sorry about the delay. Now that I think about this some more I'm not sure this is something we need from Tor.

Presently Stem's integ tests check to see if tor has cached descriptors on disk and, if so, tests that we can parse them. This test is often skipped because we don't have anything on disk. This inconsistency makes it a pretty sucky test.

Originally I added this as a quick and easy test for can Stem parse tor's current descriptors. We now have better tests for that but I left the state test around cuz... *shrug*, why not?

If we want a test for tor's ability to download the consensus and cache something parse-able to disk then yes, we need this method. However, I'm not sure if this is gonna buy us much additional coverage. Up to you.

comment:5 Changed 5 years ago by Sebastian

Hmm, we do want to keep stuff around on disk for when we restart. So I think it'd be worthwhile still?

comment:6 Changed 5 years ago by atagar

Ok, sounds good then. Maybe a more general purpose controller method for this would be one that "downloads the current tor descriptor data and tells us when it's done"? The test could then trigger that, wait for tor to cache fresh descriptors, then test that it can read the contents.

comment:7 Changed 5 years ago by Sebastian

Sounds like two separate things to me

comment:8 Changed 5 years ago by atagar

Ok. Happy to defer to whatever you think would provide the best test.

My thought was that the integ tests start a fresh tor instance, so we want it to go through its usual process of downloading and caching descriptors.

comment:9 Changed 5 years ago by Sebastian

But Tor does that by itself. Am I missing anything?

comment:10 Changed 5 years ago by atagar

Tor does that itself *eventually*. The integ tests only take around a minute to run and I believe that's less than what tor takes for tor to get around to downloading and caching to disk. Maybe I'm wrong.

comment:11 Changed 5 years ago by nickm

Status: newassigned

comment:12 Changed 4 years ago by nickm

Keywords: 027-triaged-1-in added

Marking more tickets as triaged-in for 0.2.7

comment:13 Changed 4 years ago by isabela

Keywords: SponsorS added
Points: small
Version: Tor: 0.2.7

comment:14 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:15 Changed 4 years ago by nickm

Keywords: SponsorS removed
Sponsor: SponsorS

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

comment:16 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

It is impossible that we will fix all 252 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "assigned" tickets with no owner, looking for things to move to ???.

If somebody thinks they can get these done before the 0.2.8 timeout, please assign it to yourself and move it back?

comment:17 Changed 4 years ago by isabela

Severity: Normal
Sponsor: SponsorSSponsorS-can

comment:18 Changed 3 years ago by nickm

Keywords: SponsorS-deferred added
Sponsor: SponsorS-can

Remove the SponsorS status from these items, which we already decided to defer from 0.2.9. add the SponsorS-deferred tag instead in case we ever want to remember which ones these were.

comment:19 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:20 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:21 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:22 Changed 2 years ago by nickm

Keywords: 027-triaged-in added

comment:23 Changed 2 years ago by nickm

Keywords: 027-triaged-in removed

comment:24 Changed 2 years ago by nickm

Keywords: 027-triaged-1-in removed

comment:25 Changed 2 years ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:26 Changed 2 years ago by nickm

Keywords: tor-client tor-control needs-design added; SponsorS-deferred removed
Note: See TracTickets for help on using tickets.