Tor controller command to write its file to disk

atagar wants that for the tests.

changed milestone to %Tor: unspecified

added component::core tor/tor milestone::Tor: unspecified needs-design points::small priority::medium severity::normal status::new tor-client tor-control type::defect version::tor 0.2.7 labels

Thanks Sebastian. I'll try to provide an update on Wednesday or Thursday with the details of what the tests look for and why.

What does "write its file to disk" mean in this context? What file are we talking about here?

Descriptors, state file

Hi Sebastian, sorry about the delay. Now that I think about this some more I'm not sure this is something we need from Tor.

Presently Stem's integ tests check to see if tor has cached descriptors on disk and, if so, tests that we can parse them. This test is often skipped because we don't have anything on disk. This inconsistency makes it a pretty sucky test.

Originally I added this as a quick and easy test for can Stem parse tor's current descriptors. We now have better tests for that but I left the state test around cuz... shrug, why not?

If we want a test for tor's ability to download the consensus and cache something parse-able to disk then yes, we need this method. However, I'm not sure if this is gonna buy us much additional coverage. Up to you.

Hmm, we do want to keep stuff around on disk for when we restart. So I think it'd be worthwhile still?

Ok, sounds good then. Maybe a more general purpose controller method for this would be one that "downloads the current tor descriptor data and tells us when it's done"? The test could then trigger that, wait for tor to cache fresh descriptors, then test that it can read the contents.

Sounds like two separate things to me

Ok. Happy to defer to whatever you think would provide the best test.

My thought was that the integ tests start a fresh tor instance, so we want it to go through its usual process of downloading and caching descriptors.

But Tor does that by itself. Am I missing anything?

Tor does that itself eventually. The integ tests only take around a minute to run and I believe that's less than what tor takes for tor to get around to downloading and caching to disk. Maybe I'm wrong.

Trac:
Status: new to assigned

Marking more tickets as triaged-in for 0.2.7

Trac:
Keywords: N/A deleted, 027-triaged-1-in added

Trac:
Version: N/A to Tor: 0.2.7
Keywords: N/A deleted, SponsorS added
Points: N/A to small

Trac:
Milestone: Tor: 0.2.7.x-final to Tor: 0.2.8.x-final

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

Trac:
Keywords: SponsorS deleted, N/A added
Sponsor: N/A to SponsorS

It is impossible that we will fix all 252 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "assigned" tickets with no owner, looking for things to move to ???.

If somebody thinks they can get these done before the 0.2.8 timeout, please assign it to yourself and move it back?

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.???

Trac:
Severity: N/A to Normal
Sponsor: SponsorS to SponsorS-can
Reviewer: N/A to N/A

Remove the SponsorS status from these items, which we already decided to defer from 0.2.9. add the SponsorS-deferred tag instead in case we ever want to remember which ones these were.

Trac:
Keywords: N/A deleted, SponsorS-deferred added
Sponsor: SponsorS-can to N/A

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Keywords: N/A deleted, tor-03-unspecified-201612 added
Milestone: Tor: 0.3.??? to Tor: unspecified

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: N/A deleted, 027-triaged-in added

Trac:
Keywords: 027-triaged-in deleted, N/A added

Trac:
Keywords: 027-triaged-1-in deleted, N/A added

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

Trac:
Status: assigned to new

Trac:
Keywords: SponsorS-deferred deleted, tor-client tor-control needs-design added

moved to tpo/core/tor#14827 (closed)