Opened 5 years ago

Closed 5 years ago

#14848 closed defect (fixed)

Remove mempool and freelists.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In 0.2.5, we made mempool support off-by-default and buffer freelists off-by-default. Nobody has complained. I say we remove them entirely.

Child Tickets

Attachments (1)

0001-Remove-lingering-mempool-code.patch (11.8 KB) - added by cypherpunks 5 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.6.x-final
Status: newneeds_review

See branch "remove_freelist" in my public repo.

Yawning and Andrea are okay with taking this in 0.2.6.

comment:2 Changed 5 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

I'ma merge this one as "obviously right". Hope it is...

comment:3 Changed 5 years ago by cypherpunks

Resolution: implemented
Status: closedreopened

There is some lingering #ifdef ENABLE_MEMPOOLS code lying around, and the #define itself still exists. Since it no longer even compiles when set, the attached patch removes the rest(?) of the related code.

Changed 5 years ago by cypherpunks

comment:4 Changed 5 years ago by nickm

Status: reopenedneeds_review

comment:5 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks good; applied!

Note: See TracTickets for help on using tickets.