Opened 5 years ago

Last modified 2 years ago

#14895 new enhancement

SENTCONNECT TCP RST/TIMEOUT print IP in FAILED/CLOSED

Reported by: grarpamp Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.5.10
Severity: Normal Keywords: tor-control needs-spec
Cc: rl1987@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Connect requests resulting in TCP ACK properly print the IP resolved and connected to by the exit in SUCCEEDED and CLOSED...

NEW torproject.org:80 PURPOSE=USER
SENTCONNECT torproject.org:80
REMAP 154.35.132.70:80 SOURCE=EXIT
SUCCEEDED 154.35.132.70:80
CLOSED 154.35.132.70:80 REASON=DONE

Yet those resulting in TCP RST or TIMEOUT fail to print the IP even though the IP is (if not it should be) returned and known to client in those cases as well...

NEW torproject.org:800 PURPOSE=USER
SENTCONNECT torproject.org:800
FAILED torproject.org:800 REASON=END REMOTE_REASON=CONNECTREFUSED
CLOSED torproject.org:800 REASON=END REMOTE_REASON=CONNECTREFUSED

NEW example.com:800 PURPOSE=USER
SENTCONNECT example.com:800
DETACHED example.com:800 REASON=TIMEOUT
...
FAILED example.com:800 REASON=CANT_ATTACH
CLOSED example.com:800 REASON=CANT_ATTACH

Fix:

  • Instead of the printing the SENTCONNECT fwd name, print the IP in those FAILED and CLOSED lines.
  • The IP should also be printed in DETACHED if we have it (which we should if the TIMEOUT is being returned to us in a cell from the exit, as opposed to the client timing it out).

Also, in the case of a RST, it seems something (like CONNECTING, REMAP, DETACHED or some relavent label and line) could/should be printed between SENTCONNECT and FAILED.

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

Seems worthwhile, but not must-do for 0.2.6.

comment:2 Changed 4 years ago by rl1987

Cc: rl1987@… added

comment:3 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:4 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:5 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:6 Changed 2 years ago by nickm

Keywords: tor-control needs-spec added
Severity: Normal
Type: defectenhancement
Note: See TracTickets for help on using tickets.