Opened 5 years ago

Closed 5 years ago

#14922 closed defect (implemented)

Kill tor_strclear() with fire, and replace it with memwipe().

Reported by: yawning Owned by: yawning
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords: easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Per nickm, "IMO: delete that function; change its three users to use memwipe".

Not sure about the milestone for this, tentatively setting it to 0.2.7.x, though previously stored client keys for rend services are sanitized using this, so it might be a 0.2.6.x thing.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by yawning

Owner: set to yawning
Status: newassigned

comment:2 Changed 5 years ago by yawning

Status: assignedneeds_review

https://github.com/Yawning/tor/compare/bug14922

Dunno what to put for the changes file here.

comment:3 Changed 5 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged; added a changes file as 320a68026ede1f5707b1b48f1b8c3bf34e11d931

Note: See TracTickets for help on using tickets.