Opened 4 years ago

Last modified 20 months ago

#14957 new defect

Clients wait for an extra consensus before learning the correct UseGuardFraction value

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords: tor-client, tor-guard, SponsorU-deferred, 032-unreached
Cc: Actual Points:
Parent ID: Points: .2
Reviewer: Sponsor:

Description (last modified by asn)

When clients parse the consensus, they decide whether to register any guardfraction information included based on the value of the UseGuardFraction consensus parameter. The problem is that the decision is taken in the middle of consensus parsing, but in should_apply_guardfraction() we wrongly use networkstatus_get_param(NULL, "UseGuardFraction",..." to decide whether the parameter is on or off. In that case networkstatus_get_param() will check the old consensus, and not the one that we are currently parsing and is still in unfinished state.

comment:52:ticket:9321 includes some possible fixes.

Another possible fix would be to always register guardfraction information found in the consensus. But instead check during path building time whether we should use it or not. So instead of having should_apply_guardfraction() we would have should_consider_guardfraction() or should_use_guardfraction().

Child Tickets

Change History (19)

comment:1 Changed 4 years ago by asn

Description: modified (diff)

comment:2 Changed 4 years ago by nickm

Status: newassigned

comment:3 Changed 4 years ago by nickm

Keywords: 027-triaged-1-in added

Missed these two.

comment:4 Changed 4 years ago by isabela

Keywords: SponsorU added
Points: small/medium
Version: Tor: 0.2.7

comment:5 Changed 4 years ago by nickm

Keywords: PostFreeze027 added

If we wind up with a nice patch for any of these in the appropriate window, we should sure merge it.

comment:6 Changed 4 years ago by nickm

Keywords: PostFreeze027 removed
Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

Moving these tickets into 0.2.8. Not expecting to take patches for any into 0.2.7 at this late date. As usual, please say something if you disagree! :)

comment:7 Changed 4 years ago by nickm

Keywords: SponsorU removed
Sponsor: SponsorU

Bulk-replace SponsorU keyword with SponsorU field.

comment:8 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final
Status: assignednew

Turn most 0.2.8 "assigned" tickets with no owner into "new" tickets for 0.2.9. Disagree? Find somebody who can do it (maybe you?) and get them to take it on for 0.2.8. :)

comment:9 Changed 3 years ago by isabela

Sponsor: SponsorUSponsorU-can

comment:10 Changed 3 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:11 Changed 3 years ago by nickm

Keywords: SponsorU-deferred added
Sponsor: SponsorU-can

Remove the SponsorU status from these items, which we already decided to defer from 0.2.9. add the SponsorU-deferred tag instead in case we ever want to remember which ones these were.

comment:12 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:13 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:14 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:15 Changed 2 years ago by nickm

Keywords: 027-triaged-in added

comment:16 Changed 2 years ago by nickm

Keywords: 027-triaged-in removed

comment:17 Changed 2 years ago by nickm

Keywords: 027-triaged-1-in removed

comment:18 Changed 2 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.2.x-final
Points: small/medium.2
Severity: Normal

comment:19 Changed 20 months ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

Note: See TracTickets for help on using tickets.