Opened 5 years ago

Closed 5 years ago

#14984 closed defect (fixed)

Onionoo bandwidth graphs with 2.6.3 are off

Reported by: hardlined Owned by:
Priority: Medium Milestone:
Component: Metrics/Onionoo Version: Tor: 0.2.6.3-alpha
Severity: Keywords: onionoo, 2.6.3, bandwidth, obseravations
Cc: iwakeh Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I recently updated my relay to 2.6.3 alpha and noticed the reporting for bandiwdth graphs is off, this is most apparent in globe or atlas:

Here are some 2.6.3 servers, this doesn't appear to happen with 2.6.2.

https://globe.torproject.org/#/relay/B5A7EF4AC2BDD4CE151EFF607C07A91B7CC576F6
https://globe.torproject.org/#/relay/A60DEE862B58664833311F0D13E35D537E2E5983
https://globe.torproject.org/#/relay/1C90D3AEADFF3BCD079810632C8B85637924A58E

Scrolling back through the 20th shows the problem most likely started with the release of 2.6.3.

Might have something to do with:

https://trac.torproject.org/projects/tor/ticket/13988

From the release notes:

o Minor bugfixes (statistics):

  • Increase period over which bandwidth observations are aggregated from 15 minutes to 4 hours. Fixes bug 13988; bugfix on 0.0.8pre1.

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by karsten

Cc: iwakeh added

Indeed, that change in tor is what causes these problems. Thanks for the detailed bug report!

Please someone review my branch task-14984. It's a short fix, though the surrounding code is messy. I'm going to deploy that branch on the Onionoo mirror tomorrow. Regarding versions, I'm thinking about raising the protocol version to 2.3.0, because we're removing optional fields, notably the "3_days" and "1_week" bandwidth graphs for relays running tor 0.2.6.3 or later. I should also announce this change on onionoo-announce@, though I really don't want to wait a month before deploying it, because this a bug that can confuse users. Thoughts welcome.

comment:2 Changed 5 years ago by karsten

Status: newneeds_review

comment:3 Changed 5 years ago by karsten

Rebased and deployed on the Onionoo mirror. I'll let it run a few more days before deploying on the main instance.

comment:4 Changed 5 years ago by iwakeh

The changes should run fine, but still good to let it run a while.

Regarding the protocol version, I would opt for bugfix version 2.2.1 instead of minor change version 2.3.0.
It feels more like a bugfix b/c it is due to an (unforeseen) lack of data for certain (i.e. the newer) platforms.
The code change addresses the lack of data, so it is really a bugfix.

The interdependency of platform data and other available data is not a protocol issue.

comment:5 Changed 5 years ago by karsten

Status: needs_reviewnew

Thanks for looking! Makes sense to bump to 2.2.1, not 2.3.0. By the way, the branch I'm running on the mirror is task-14984-2.

comment:6 Changed 5 years ago by karsten

Resolution: fixed
Status: newclosed

The mirror did not fall apart, merging to master. Resolving. Thanks!

Note: See TracTickets for help on using tickets.