Opened 5 years ago

Closed 5 years ago

#14992 closed defect (fixed)

Incremental MAR files are not recreated if old ones are still existing

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201503R
Cc: boklm, brade, mcs, mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


While rebundling we realized that no new incremental MAR files got created as the old ones were still available: I had to delete them manually to get new ones. I think the correct behavior would be to just overwrite the old incrementals with the new ones.

Child Tickets

Attachments (1)

0001-Bug-14992-regenerate-existing-incremental-MAR-files.patch (1.7 KB) - added by boklm 5 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 5 years ago by mcs

Cc: brade mcs added

I think this behavior was designed to save time (generating incremental MAR files is slow). But it sounds like it is also dangerous, so we either need to make sure we always regenerate them or we need to regenerate them whenever the source files (i.e., the complete MAR files) have changed.

comment:2 Changed 5 years ago by boklm

Keywords: TorBrowserTeam201503R added
Status: newneeds_review

I'm attaching a patch to always generate incremental MAR files, even if they are already present.

comment:3 Changed 5 years ago by mcs

The patch looks good (reviewed by Kathy and me).

comment:4 in reply to:  3 Changed 5 years ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Thanks for the review. Pushed on master as commit 010d6f55a4060b0dbb8e0c779f857bb35fbf0f36 and on maint-4.0 as commit 9415032ccc373f96d3b7be4cf98ebe4d7bdf20e0.

Note: See TracTickets for help on using tickets.