Opened 4 years ago

Last modified 2 years ago

#14999 new defect

Most/all esc_for_log instances in control.c should change.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, tor-control needs-design
Cc: atagar, brade, mcs, gk Actual Points:
Parent ID: Points: medium
Reviewer: Sponsor:

Description

In the discussion on ticket #14555 and earlier on #4600, we realized that esc_for_log() should not be used for strings sent to the controller.

Unfortunately it is, so in b9302fb0aa2d5b635002bc5bf50219d42b90d9d7 and later I documented that.

But we should fix it instead.

Child Tickets

Change History (19)

comment:1 Changed 4 years ago by mcs

Cc: brade mcs added

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

These may be worth looking at for 0.2.7.

comment:3 Changed 4 years ago by nickm

Status: newassigned

comment:4 Changed 4 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:6 Changed 4 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.8.x-final

comment:7 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???
Points: medium

comment:8 Changed 4 years ago by gk

Cc: gk added
Severity: Normal

comment:9 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:10 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:11 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:12 Changed 2 years ago by nickm

Keywords: 027-triaged-in added

comment:13 Changed 2 years ago by nickm

Keywords: 027-triaged-in removed

comment:14 Changed 2 years ago by nickm

Keywords: 027-triaged-1-out removed

comment:15 Changed 2 years ago by dgoulet

Keywords: controller added

Unify controller keyword to "tor-control".

comment:16 Changed 2 years ago by dgoulet

Keywords: tor-control added; controller removed

Unify "controller" keyword to "tor-control".

comment:17 Changed 2 years ago by dgoulet

Keywords: tor-controller removed

Cleanup remaining "tor-controller" that already have "tor-control"

comment:18 Changed 2 years ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:19 Changed 2 years ago by nickm

Keywords: tor-spec needs-design added; spec removed

See also #15000 .

Note: See TracTickets for help on using tickets.