Opened 5 years ago

Closed 5 years ago

#15010 closed defect (fixed)

Hidden service descriptor spec clarifications

Reported by: atagar Owned by:
Priority: Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi Nick, as per #15004 I'm adding the ability to parse hidden service descriptors to Stem. In general the rend-spec is delightfully clear, though there's a couple spots that could do with clarification...

  • The 'version' and 'protocol-versions' fields are defined as a version-number which isn't a thing. In practice these versions are presently integers, but I need for the spec to explicitly either say they're integers or what they can contain. This will determine if they're an int or str in Stem.
  • The 'introduction-points' contains a 'ip-address' with a field defined as a ip-address. Again, that's not a well defined type. For this one I'm curious 'is this IPv4? IPv6? Would IPv32 be cool too?'. This will determine if/how I try to validate this field.

Cheers! -Damian

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by nickm

Keywords: tor-spec added
Milestone: Tor: 0.2.7.x-final

comment:2 Changed 5 years ago by nickm

version-number should be a nonnegative int.

I believe ip-address has to be ipv4, given how old this document type is.

Could somebody please patch the spec?


comment:3 Changed 5 years ago by atagar

Status: newneeds_review

Thanks Nick! Made a couple quick tweaks in my 15010 branch...

https://gitweb.torproject.org/user/atagar/torspec.git/log/?h=15010

comment:4 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged! Thanks!

Note: See TracTickets for help on using tickets.