Opened 4 years ago

Closed 4 years ago

#15024 closed defect (fixed)

Improve configure help layout

Reported by: cypherpunks Owned by:
Priority: Very Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The result of ./configure --help has a number of capitalization, quoting and spacing inconsistencies. Standard autoconf options have their descriptions start with lowercase, not all custom options do this. Quoting prevents parameters from being interpreted incorrectly and is not done everywhere. Finally, the AS_HELP_STRING macro should be used so spacing is automatically fixed and everything is aligned in neat columns. The attached patch fixes these inconsistencies.

Child Tickets

Attachments (1)

0001-Be-consistent-with-capitalization-quoting-and-spacin.patch (9.8 KB) - added by cypherpunks 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-final
Status: newneeds_review

comment:2 Changed 4 years ago by qbi

The patch looks good to me. However I'd suggest to refrain from lower-casing the word OpenBSD (line 29 in configure.ac), especially since other words like UPnP etc. also don't have an all-lowercase name.

comment:3 in reply to:  2 Changed 4 years ago by cypherpunks

Replying to qbi:

The patch looks good to me. However I'd suggest to refrain from lower-casing the word OpenBSD (line 29 in configure.ac), especially since other words like UPnP etc. also don't have an all-lowercase name.

This is also corrected by the patch.

comment:4 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Yup, looks ok to me. Merged!

Note: See TracTickets for help on using tickets.