Opened 6 years ago

Closed 6 years ago

#15026 closed enhancement (fixed)

Log version on LD_BUG

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Some people post only the bug line when they get an LD_BUG message and don't say their version. Might be worth sticking the tor version onto that line?

Child Tickets

Change History (7)

comment:1 Changed 6 years ago by nickm

Status: newneeds_review

Implemented in 'feature15026'. Not sure if it's a good idea or no.

comment:2 Changed 6 years ago by nickm

I'm now thinking this is a good idea.

comment:3 Changed 6 years ago by Sebastian

I agree, but this patch is wrong I believe. The n += 5 needs to be a n += strlen(bug_prefix), and the buf_len-n > strlen() needs to be a buf_len-n > strlen() + 1, I believe?

comment:4 Changed 6 years ago by Sebastian

Status: needs_reviewneeds_revision

comment:5 Changed 6 years ago by nickm

I went to fix this, and when I tested it out, I didn't like the format:

Mar 14 13:41:22.000 [warn] int do_main_loop()(): Bug (0.2.7.0-alpha-dev 93c2da13de84da9b): Foo bar baz

Instead, have a look at branch feature15026_v2:

Mar 14 13:48:58.000 [warn] int do_main_loop()(): Bug: Foo bar baz (on Tor 0.2.7.0-alpha-dev 4247ce99e5d9b7b2)

How's that ?

comment:6 Changed 6 years ago by Sebastian

Looks good. We should fix that ()() business, but that's not new in your patch afaict

comment:7 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_revisionclosed

Looks good.

Thanks, merged!

We should fix that ()() business, but that's not new in your patch afaict

Right; that's #15269.

Note: See TracTickets for help on using tickets.