Log version on LD_BUG

Some people post only the bug line when they get an LD_BUG message and don't say their version. Might be worth sticking the tor version onto that line?

changed milestone to %Tor: 0.2.7.x-final

added component::core tor/tor milestone::Tor: 0.2.7.x-final priority::medium resolution::fixed status::closed type::enhancement labels

Implemented in 'feature15026'. Not sure if it's a good idea or no.

Trac:
Status: new to needs_review

I'm now thinking this is a good idea.

I agree, but this patch is wrong I believe. The n += 5 needs to be a n += strlen(bug_prefix), and the buf_len-n > strlen() needs to be a buf_len-n > strlen() + 1, I believe?

Trac:
Status: needs_review to needs_revision

I went to fix this, and when I tested it out, I didn't like the format:

Mar 14 13:41:22.000 [warn] int do_main_loop()(): Bug (0.2.7.0-alpha-dev 93c2da13de84da9b): Foo bar baz

Instead, have a look at branch feature15026_v2:

Mar 14 13:48:58.000 [warn] int do_main_loop()(): Bug: Foo bar baz (on Tor 0.2.7.0-alpha-dev 4247ce99e5d9b7b2)

How's that ?

Looks good. We should fix that ()() business, but that's not new in your patch afaict

Looks good.

Thanks, merged!

We should fix that ()() business, but that's not new in your patch afaict

Right; that's #15269 (moved).

Trac:
Resolution: N/A to fixed
Status: needs_revision to closed

closed

moved to tpo/core/tor#15026 (closed)