Opened 4 years ago

Closed 3 years ago

#15087 closed defect (implemented)

Move timeliness check out of tor_cert_checksig, or into tor_cert_get_checkable_sig

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords: 027-triaged-1-in, 028-triaged tor-ed25519-proto TorCoreTeam201608
Cc: Actual Points:
Parent ID: #15054 Points: 1
Reviewer: Sponsor: SponsorU-can

Description

There's a mismatch in our certificate API: When we're doing single verification, we check the expiration time, but when we are doing batch verification, we rely on the caller to do so. We should make these functions do the same thing.

Child Tickets

Change History (15)

comment:1 Changed 4 years ago by nickm

Status: newassigned

comment:2 Changed 4 years ago by nickm

Keywords: 027-triaged-1-in added

Marking more tickets as triaged-in for 0.2.7

comment:3 Changed 4 years ago by isabela

Keywords: SponsorU added
Points: small
Priority: normalmajor
Version: Tor: 0.2.7

comment:4 Changed 4 years ago by nickm

Owner: set to nickm

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

Moving these tickets into 0.2.8. Not expecting to take patches for any into 0.2.7 at this late date. As usual, please say something if you disagree! :)

comment:6 Changed 4 years ago by nickm

Keywords: 028-triaged added

comment:7 Changed 4 years ago by nickm

Keywords: SponsorU removed
Sponsor: SponsorU

Bulk-replace SponsorU keyword with SponsorU field.

comment:8 Changed 3 years ago by nickm

Priority: HighMedium

comment:9 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

These seem like features, or like other stuff unlikely to be possible this month. Bumping them to 0.2.9

comment:10 Changed 3 years ago by isabela

Sponsor: SponsorUSponsorU-can

comment:11 Changed 3 years ago by nickm

Keywords: tor-ed25519-proto added
Severity: Normal

comment:12 Changed 3 years ago by isabela

Points: small1

comment:13 Changed 3 years ago by nickm

Keywords: TorCoreTeam201608 added

comment:14 Changed 3 years ago by nickm

Done as part of my 15055_wip branch

comment:15 Changed 3 years ago by nickm

Resolution: implemented
Status: assignedclosed

Folding this back into #15055 , where it is implemented.

Note: See TracTickets for help on using tickets.