Opened 9 years ago

Closed 4 years ago

#1515 closed enhancement (implemented)

Torbutton shold enable firefox's "Private Browsing Mode"

Reported by: mikeperry Owned by:
Priority: High Milestone:
Component: Applications/Torbutton Version:
Severity: Normal Keywords:
Cc: michael@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

We need to integrate with Firefox's Private Browsing Mode. A lot of people suggest to me that we should turn Tor on whenever Private Browsing is enabled. I think this is the wrong way to go -- but we should turn on PBM when we get enabled. This is useful for us primarily because enabling PBM will tell other addons that they also need to be private.

However, doing so will require some gymnastics to preserve Torbutton features. See: https://gitweb.torproject.org/torbutton.git/blob_plain/HEAD:/website/design/FF35_AUDIT

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by mikeperry

Component: Tor-Tor clientTor-Torbutton

comment:2 Changed 9 years ago by elehack

Cc: michael@… added

comment:3 Changed 9 years ago by mikeperry

Description: modified (diff)

After some consideration, I think the best way to do this is to provide two options. One option should be "Enter Private Browsing Mode when Tor is enabled", and should disable the ability to set all the options relevant to things that Firefox already sets. This should be off by default.

The other option should be "Inform other addons that we are entering into a private mode", and should enumerate all observers that listen for the "private-browsing" and related observer events, and send the ones not owned by Firefox the event. We should also possibly wrap the private browsing service and provide fake values for its "privateBrowsingEnabled" boolean. This would serve the purpose of telling other addons to behave and not leak private data. However, wrapping that boolean may cause unknown side-effects in Firefox. Another Firefox code review would be required.

comment:4 Changed 4 years ago by bugzilla

Resolution: implemented
Severity: Normal
Status: newclosed
Note: See TracTickets for help on using tickets.