Opened 4 years ago

Closed 21 months ago

#15157 closed defect (fixed)

Spec issues with consensus' new 'package' field

Reported by: atagar Owned by: nickm
Priority: Low Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: brade, mcs Actual Points:
Parent ID: Points: .1
Reviewer: Sponsor:

Description

Hi Nick. Brought these up on irc but moving to a ticket. Our consensus' new unused packages field has some spec issues...

  • It isn't very future proof. It's fine for now, but I'm not sure how it could validly have new attributes in the future.
  • Presently it necessitates at least one DIGEST entry. Think that's probably a mistake.
  • 'one or more non-=, non-" " characters' => That's too imprecise. For instance, it allows newlines which I'm sure wouldn't really be valid.
  • It would be nice if it said if a DIGESTTYPE can appear multiple times. I'd like to model this as a hash but I'm not sure if DIGESTTYPE are unique.

Child Tickets

Change History (16)

comment:1 Changed 4 years ago by mcs

Cc: brade mcs added

comment:2 Changed 4 years ago by atagar

Added stem support. Presently I'm assuming digests are optional.

comment:3 Changed 4 years ago by nickm

Milestone: Tor: 0.2.6.x-final

comment:4 Changed 4 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.7.x-final

comment:5 Changed 4 years ago by nickm

Status: newassigned

comment:6 Changed 4 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:7 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:8 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:9 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:10 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:11 Changed 22 months ago by nickm

Keywords: 027-triaged-in added

comment:12 Changed 22 months ago by nickm

Keywords: 027-triaged-in removed

comment:13 Changed 22 months ago by nickm

Keywords: 027-triaged-1-out removed

comment:14 Changed 22 months ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:15 Changed 21 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.1.x-final
Owner: set to nickm
Points: .1
Severity: Normal
Status: newaccepted

comment:16 Changed 21 months ago by nickm

Resolution: fixed
Status: acceptedclosed

I've cleaned up the incorrectness wrt the specification of DIGESTVAL and DIGESTTYPE in 5b7a7d6264f24c

It's not a mistake that DIGEST is mandatory; it is indeed required.

The future-proofing can be handled by adding new k=v entries that don't have to be digests.

A digesttype needs to be unique -- it is something like "sha1" or "sha256". We can't have more than one of each type for a given object.

I've also sent an email to tor-dev asking if we intend to use these at all.

Note: See TracTickets for help on using tickets.