Opened 6 years ago

Closed 6 years ago

#15180 closed enhancement (implemented)

Add make rule for verifying changes files format

Reported by: cypherpunks Owned by:
Priority: Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


There is a maintenance script for verifying the format of changes files. Wouldn't it be a good idea to integrate it in the build configuration so developers can easily verify their changes files? This would improve the quality of the changes files, leading to less work when building the changelog.

I already got a patch ready but i am wondering if anyone is interested in this feature.

Child Tickets

Attachments (3)

0001-Add-check-changes-rule-for-checking-formatting-of-ch.patch (4.0 KB) - added by cypherpunks 6 years ago.
0002-Be-exact-about-the-number-of-spaces-in-the-header.patch (1.2 KB) - added by cypherpunks 6 years ago.
0003-Warn-about-blank-lines.patch (2.4 KB) - added by cypherpunks 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by nickm

Milestone: Tor: 0.2.7.x-final

I'm loosely interested. Depends on the interface. The checker is advisory rather than mandatory, and sometimes it is too restrictive, so I don't want to force "don't build unless this passes".

Changed 6 years ago by cypherpunks

comment:2 Changed 6 years ago by cypherpunks

Status: newneeds_review

The main patch is 0001. It is modeled after check-spaces so it is advisory and not mandatory. Patches 0002 and 0003 are small improvements to the script to be more strict about the header and blank lines.

comment:3 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Thanks! Merged the first 2; didn't take the third, since my cleanup tools (sortChanges, formatChangelog) take care of missing blank lines just fine.

Note: See TracTickets for help on using tickets.