Opened 5 years ago

Closed 5 years ago

#15188 closed defect (fixed)

Fix side-effect in tor_assert expr

Reported by: TvdW Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.6.3-alpha
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In testing_common.c there's a call to tor_assert() that contains an expression with a side-effect. We should probably split those up.

Potential patch: https://github.com/TvdW/tor/commit/6e4f7704198d2b7332e6ec388e8c2ffbe51384b7

Child Tickets

Change History (2)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-final
Status: newneeds_review

comment:2 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Applied to 0.2.6; merged forwards. Thanks!

Note: See TracTickets for help on using tickets.