Opened 5 years ago

Last modified 2 years ago

#15214 new defect

networkstatus_compute_consensus() is unreasonably large and should be refactored

Reported by: andrea Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: tor-client refactor technical-debt intro
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I count 874 lines (while auditing strlcat()/strlcpy() calls). Did Minicode raise our function call ration from 25 to 20 per 100 kloc the week this was written?

Child Tickets

Change History (12)

comment:1 Changed 5 years ago by nickm

before you mess with this, be aware that my #12498 branch makes some changes to that function; you might want to base any tweaks on that.

comment:2 Changed 5 years ago by nickm

Status: newassigned

comment:3 Changed 5 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 3 years ago by nickm

Keywords: 027-triaged-in added

comment:9 Changed 3 years ago by nickm

Keywords: 027-triaged-in removed

comment:10 Changed 3 years ago by nickm

Keywords: 027-triaged-1-out removed

comment:11 Changed 3 years ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:12 Changed 2 years ago by nickm

Keywords: tor-client refactor technical-debt intro added
Severity: Normal
Note: See TracTickets for help on using tickets.