Opened 5 years ago

Closed 4 years ago

#15247 closed defect (wontfix)

make check-spaces runs configure

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-03-unspecified-201612
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


which really surprised me. At some point I should learn why and try and fix it

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by cypherpunks

This could be caused by some files related to the build system being changed between runs (for example when switching between branches). Simply touching any of the files in m4/, or triggers it. AFAIK this is a feature of autotools to keep the build configuration current.

Run make -d check-spaces | grep -e "newer than" -e "Must remake" to see which files trigger the remaking of other files.

comment:2 Changed 4 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 4 years ago by cypherpunks

Severity: Normal
Status: newneeds_information

Is there anything to do for this ticket?

comment:4 Changed 4 years ago by nickm

I'm thinking there probably isn't. Any objections to closing this?

comment:5 Changed 4 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 4 years ago by teor

I would like to fix this so make check-spaces is independent of ./configure and its dependencies. There is probably some magic .Thingy somewhere.

comment:7 Changed 4 years ago by nickm

I don't think that will work; until configure has run, we simply don't _have_ a makefile that make will recognize.

comment:8 Changed 4 years ago by teor

Resolution: wontfix
Status: needs_informationclosed

I'm ok if make check-spaces requires ./configure the first time.

But I can't see any reason why changes to the checkout should require the Makefile to be rebuilt by ./configure before make check-spaces is run.

Then again, if it ever does matter, that would cause subtle bugs. So I think it's best to wontfix this.

Note: See TracTickets for help on using tickets.