autoconf: drop workarounds for libevent <1.3

All of our checks for u_int_* in configure.ac are unneeded, since Libevent stopped littering its headers with those in 1.3.

Similarly, there are functions that we're checking for which libevent probably has unconditionally in all the versions we support.

changed milestone to %Tor: 0.2.7.x-final

added 027-triaged-1-out autoconf component::core tor/tor libevent milestone::Tor: 0.2.7.x-final priority::low resolution::implemented status::closed type::defect labels

Branch remove_old_libevent_autoconf_stuff has a patch that removes the autoconf stuff, and more.

Trac:
Status: new to needs_review

Marking triaged-out items from first round of 0.2.7 triage.

Trac:
Keywords: autoconf libevent deleted, autoconf, libevent, 027-triaged-1-out added

Looks ok.

Should we leave tor_check_libevent_version() and the associated control event in the code on the off chance that something goes horribly wrong in the future? ("No" is a fine answer, but that's the only place that generates BAD_LIBEVENT so we should remove it from control-spec.txt as well if we take the patch as is.)

Replying to yawning:

Looks ok.

Should we leave tor_check_libevent_version() and the associated control event in the code on the off chance that something goes horribly wrong in the future? ("No" is a fine answer, but that's the only place that generates BAD_LIBEVENT so we should remove it from control-spec.txt as well if we take the patch as is.)

I think it's fine to remove the control event and tor_check_libevent_version(); there hasn't been a version that broken in use in a long time.

Removing BAD_LIBEVENT from the spec is a different matter though. It is IMO fine for us to specify that controllers must handle a given error code or event, even if it is one that Tor no longer generates.

Ok, LGTM then.

Merged!

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

closed

moved to tpo/core/tor#15248 (closed)