Opened 4 years ago

Closed 4 years ago

#15248 closed defect (implemented)

autoconf: drop workarounds for libevent <1.3

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: autoconf, libevent, 027-triaged-1-out
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

All of our checks for u_int_* in configure.ac are unneeded, since Libevent stopped littering its headers with those in 1.3.

Similarly, there are functions that we're checking for which libevent probably has unconditionally in all the versions we support.

Child Tickets

Change History (6)

comment:1 Changed 4 years ago by nickm

Status: newneeds_review

Branch remove_old_libevent_autoconf_stuff has a patch that removes the autoconf stuff, and more.

comment:2 Changed 4 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:3 Changed 4 years ago by yawning

Looks ok.

Should we leave tor_check_libevent_version() and the associated control event in the code on the off chance that something goes horribly wrong in the future? ("No" is a fine answer, but that's the only place that generates BAD_LIBEVENT so we should remove it from control-spec.txt as well if we take the patch as is.)

comment:4 in reply to:  3 Changed 4 years ago by nickm

Replying to yawning:

Looks ok.

Should we leave tor_check_libevent_version() and the associated control event in the code on the off chance that something goes horribly wrong in the future? ("No" is a fine answer, but that's the only place that generates BAD_LIBEVENT so we should remove it from control-spec.txt as well if we take the patch as is.)

I think it's fine to remove the control event and tor_check_libevent_version(); there hasn't been a version that broken in use in a long time.

Removing BAD_LIBEVENT from the spec is a different matter though. It is IMO fine for us to specify that controllers must handle a given error code or event, even if it is one that Tor no longer generates.

comment:5 Changed 4 years ago by yawning

Ok, LGTM then.

comment:6 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.