Opened 5 years ago

Closed 4 years ago

#15265 closed defect (fixed)

obfs4proxy should use "golang.org/x/net/proxy"

Reported by: yawning Owned by: yawning
Priority: Medium Milestone:
Component: Circumvention/Pluggable transport Version:
Severity: Keywords: obfs4proxy, golang, gitian, TorBrowserTeam201503R, GeorgKoppen201503R, tbb-4.5-alpha
Cc: gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by yawning)

I should have changed this when I dealt with the "go.crypto" repository move, but I didn't.

It's a simple change of import paths in 3 files, but this breaks packaging and the TBB nightly builds if I commit it, so I'm opening a ticket to ensure that the right things happen in all the relevant places.

This isn't particularly high priority since the old code still works, but switching to this, and having Tor Browser pull it in will let me kill off the go.net tarball that's used as part of the 4.5a build.

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by yawning

Description: modified (diff)

comment:2 Changed 4 years ago by yawning

Cc: gk added
Keywords: gitian TorBrowserTeam201503 tbb-4.5-alpha added

The tor-browser gitian changes: https://github.com/Yawning/tor-browser-bundle/compare/bug15265

Like the last time I did this, untested but since I copy/pasted the golang.org/x/net stuff, it's more than likely correct. No huge rush, except that this has to happen by sometime next year since code.google.com is supposedly going away, and I will more than likely merge the obfs4proxy branch soon-ish.

comment:3 Changed 4 years ago by gk

Keywords: TorBrowserTeam201503R GeorgKoppen201503R added; TorBrowserTeam201503 removed
Status: newneeds_review

comment:4 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good, thanks. I just made the commit message a bit "prettier". Merged as commit 474bbb5e54acae925a849e77b8ef590e58ee0820.

Note: See TracTickets for help on using tickets.