Opened 5 years ago

Closed 3 years ago

#15297 closed enhancement (invalid)

add an additional check in MULTI_INSTANCE mode for a more obvious error message

Reported by: cypherpunks Owned by: hiviah
Priority: Medium Milestone:
Component: Core Tor/RPM packaging Version:
Severity: Normal Keywords:
Cc: nusenu@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If the user enabled multi_instance mode but didn't create /etc/tor/enabled he gets a unclear error message about file "*".

This additional check should make it more obvious whats wrong.

Proposed chage:
Add the following check in line 210:

if ! ls $CONFDIR/*.torrc > /dev/null 2>&1
then
 echo "torrc file(s) missing in $CONFDIR"
 exit 1
fi

https://github.com/nusenu/tor-multi-instance-initscripts/commit/f8c4b8bc53d803c09060e4f15b8118aad01e61e5

Child Tickets

Change History (6)

comment:1 Changed 5 years ago by cypherpunks

small adjustment to the return code: should be 5 (not 1).

exit 5

comment:2 Changed 5 years ago by hiviah

Please make this a proper patch against branch rpm-release-0.2.6 of repo https://gitweb.torproject.org/user/hiviah/rpm-tor.git.

I.e. clone the rpm-tor repo, checkout branch 'rpm-release-0.2.6', make changes, commit and push to your github repository. Then point me at the branch with the changes. Alternatively use 'git format-patch' and attach the formatted patch as attachment here.

comment:3 Changed 5 years ago by tyseom

Cc: nusenu@… added

comment:5 Changed 5 years ago by hiviah

Merged into 0.2.6.5, available for testing in 0.2.6.5 rpm package.

comment:6 Changed 3 years ago by cypherpunks

Resolution: invalid
Severity: Normal
Status: newclosed

The torproject does not longer provide RPMs.

Note: See TracTickets for help on using tickets.