Opened 4 years ago

Closed 13 months ago

#15333 closed defect (fixed)

Minor control-spec.txt corrections.

Reported by: yawning Owned by: nickm
Priority: Very Low Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Normal Keywords: tor-spec, tor-control, doc, easy
Cc: gk Actual Points:
Parent ID: Points: 0.1
Reviewer: Sponsor:

Description

Re: SETCONF:

Tor responds with a "250 configuration values set" reply on success.
If some of the listed keywords can't be found, Tor replies with a

According to git blame that hasn't been the case since... 2008? 2007?

      case SETOPT_OK:
        config_free_lines(lines);
        send_control_done(conn);
        return 0;

Sent from the client to the server. The syntax is as for GETCONF:

"GETINFO" 1*(SP keyword) CRLF

one or more NL-terminated strings. The server replies with an INFOVALUE
message, or a 551 or 552 error.

"one or nor NL-terminated strings" is confusing. Did a newline and a word get cutoff somewhere, or am I just being dense?

Child Tickets

Change History (19)

comment:1 in reply to:  description ; Changed 4 years ago by special

Replying to yawning:

Re: SETCONF:

Tor responds with a "250 configuration values set" reply on success.
If some of the listed keywords can't be found, Tor replies with a

According to git blame that hasn't been the case since... 2008? 2007?

Do you mean that the text is different? Current tor responds with '250 OK'.

Sent from the client to the server. The syntax is as for GETCONF:

"GETINFO" 1*(SP keyword) CRLF

one or more NL-terminated strings. The server replies with an INFOVALUE
message, or a 551 or 552 error.

"one or nor NL-terminated strings" is confusing. Did a newline and a word get cutoff somewhere, or am I just being dense?

INFOVALUE also isn't defined or used anywhere else. Both of those issues date back to 2005.

comment:2 in reply to:  1 Changed 4 years ago by yawning

Replying to special:

Replying to yawning:

Re: SETCONF:

Tor responds with a "250 configuration values set" reply on success.
If some of the listed keywords can't be found, Tor replies with a

According to git blame that hasn't been the case since... 2008? 2007?

Do you mean that the text is different? Current tor responds with '250 OK'.

Indeed. It stood out as the only thing not documented to return 250 OK.

Sent from the client to the server. The syntax is as for GETCONF:

"GETINFO" 1*(SP keyword) CRLF

one or more NL-terminated strings. The server replies with an INFOVALUE
message, or a 551 or 552 error.

"one or nor NL-terminated strings" is confusing. Did a newline and a word get cutoff somewhere, or am I just being dense?

INFOVALUE also isn't defined or used anywhere else. Both of those issues date back to 2005.

Yup. Should figure out what it should say.

comment:3 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-final

comment:4 Changed 4 years ago by nickm

Status: newassigned

comment:5 Changed 3 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:6 Changed 3 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:7 Changed 3 years ago by gk

Cc: gk added
Severity: Normal

comment:8 Changed 23 months ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:9 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:10 Changed 16 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:11 Changed 16 months ago by nickm

Keywords: 027-triaged-in added

comment:12 Changed 16 months ago by nickm

Keywords: 027-triaged-in removed

comment:13 Changed 16 months ago by nickm

Keywords: 027-triaged-1-out removed

comment:14 Changed 16 months ago by dgoulet

Keywords: controller added

Unify controller keyword to "tor-control".

comment:15 Changed 16 months ago by dgoulet

Keywords: tor-control added; controller removed

Unify "controller" keyword to "tor-control".

comment:16 Changed 16 months ago by dgoulet

Keywords: tor-controller removed

Cleanup remaining "tor-controller" that already have "tor-control"

comment:17 Changed 16 months ago by nickm

Status: assignednew

Change the status of all assigned/accepted Tor tickets with owner="" to "new".

comment:18 Changed 15 months ago by nickm

Keywords: doc easy added
Milestone: Tor: unspecifiedTor: 0.3.2.x-final
Owner: set to nickm
Points: 0.1
Status: newaccepted

comment:19 Changed 13 months ago by nickm

Resolution: fixed
Status: acceptedclosed

d92fc8b17b207c fixes this.

The INFOVALUE thing was left over from control-spec-v0.txt

Note: See TracTickets for help on using tickets.