Opened 10 years ago

Closed 10 years ago

Last modified 4 years ago

#1535 closed defect (fixed)

Vidalia russian translation file broken

Reported by: phobos Owned by: runa
Priority: Medium Milestone: Tor: unspecified
Component: Community/Translations Version: Tor: unspecified
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


LangString: "PolipoAppDesc" 1049 "Óñòàíîâèòü Polipo"
LangString expects 3 parameters, got 4.
Usage: LangString [un.]name lang_id string
!include: error in script: "vidalia_ru.nsh" on line 30

Child Tickets

Change History (9)

comment:1 Changed 10 years ago by phobos

Owner: set to phobos
Status: newaccepted

comment:2 Changed 10 years ago by arma

Component: Tor ClientTranslations

Reassigning to 'translations' component.

Runa, can you make any sense of this?

Phobos, is it still an issue?

comment:3 Changed 10 years ago by phobos

Component: TranslationsTor bundles/installation
Owner: changed from phobos to erinn
Status: acceptedassigned

It's a problem with the way the nsi compiler interprets the language, not a translation issue.

comment:4 Changed 10 years ago by erinn

Component: Tor bundles/installationTranslations
Owner: changed from erinn to runa

I've found the problem with this bug, and fixed it by hand in the latest Windows packages. In vidalia_ru.po there are two lines with double-quotes:

Line 204: msgstr "Добавить в Меню \"Пуск\""
("Add to Start Menu.")
Fix: msgstr "Добавить в Меню Пуск"

Line 208: msgstr "Добавить ${POLIPO_NAME} в ваше меню \"Пуск\"."
("Add ${POLIPO_NAME} to your Start menu.")
Fix: msgstr "Добавить ${POLIPO_NAME} в ваше меню Пуск."

This makes nsis think it's getting more arguments than it actually is. Removing the quotes around Пуск as above fixes the problem. I'd commit the changes to vidalia_ru.po myself, but I don't know how that messes up Transifex, nor am I confident enough in my Russian to determine if the sentences ought to be re-worked in some way, so I'm reassigning this to Translations.

comment:5 Changed 10 years ago by runa

I can't seem to find those lines in vidalia_ru.po. Can you please paste both the original English string and the translation?

Fwiw, you can remove the quotes without breaking anything in Transifex or Pootle. Carolyn sent an email to our Russian translator last night to check if the string still makes sense without the quotes.

comment:6 Changed 10 years ago by erinn

They're in pkg/win32/ru/vidalia_ru.po not the normal .po file, apologies for not making that clear.

msgctxt "PolipoShortcuts"
msgid "Add to Start Menu"
msgstr "Добавить в Меню \"Пуск\""

msgctxt "PolipoShortcutsDesc"
msgid "Add ${POLIPO_NAME} to your Start menu."
msgstr "Добавить ${POLIPO_NAME} в ваше меню \"Пуск\"."

comment:7 Changed 10 years ago by carolyn

Ok to remove quotes per Vitaliy

comment:8 Changed 10 years ago by runa

Resolution: fixed
Status: assignedclosed

comment:9 Changed 4 years ago by isabela

Component: User Experience/TranslationsCommunity/Translations
Note: See TracTickets for help on using tickets.