Opened 4 years ago

Closed 4 years ago

#15377 closed enhancement (implemented)

Test memwipe for correct behavior

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: testing SponsorS
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

#7419 included a test for memwipe, and a patch for memwipe. We don't want to take the latter right now, but more tests are always good.

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by nickm

Moved the test into memwipe_test, and refactored its driver logic.

comment:2 Changed 4 years ago by nickm

Status: newneeds_review

Moved the test into memwipe_test, and refactored its driver logic.

comment:3 Changed 4 years ago by TvdW

Looks good to me. Nice touch on the function pointers to prevent inlining and other optimizations.

Last edited 4 years ago by TvdW (previous) (diff)

comment:4 Changed 4 years ago by dgoulet

lgtm!

Minor fix in branch bug15377_027_01. Add test-memwipe to .gitignore and add libor.a to include.am so test-memwipe can actually be built :).

comment:5 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged that; let's see how it goes!

Note: See TracTickets for help on using tickets.