Opened 4 years ago

Closed 3 years ago

#15381 closed defect (fixed)

cosmetic issue in log message : v0.1.2.3 versus 0.2.3.4

Reported by: toralf Owned by:
Priority: Very Low Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 027-triaged-1-out easy
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

The following 2 subsequent log messages let me wonder, why there's a "v" in one, but not in the other (or why is there)

Mar 19 21:18:25.000 [notice] Tor 0.2.6.5-rc (git-e0b77cd3194d705f) opening log file.                                                                                                    
Mar 19 21:18:25.258 [notice] Tor v0.2.6.5-rc (git-e0b77cd3194d705f) running on Linux with Libevent 2.0.22-stable, OpenSSL 1.0.1l and Zlib 1.2.8.                                        

Child Tickets

Change History (11)

comment:1 Changed 4 years ago by gk

Component: - Select a componentTor

comment:2 Changed 4 years ago by cypherpunks

These lines are printed by src/or/main.c:2521-2526

log_notice(LD_GENERAL, "Tor v%s %srunning on %s with Libevent %s, "
           "OpenSSL %s and Zlib %s.", version, bev_str,
           get_uname(),
           tor_libevent_get_version_str(),
           crypto_openssl_get_version_str(),
           tor_zlib_get_version_str());

and src/common/log.c:254-260

if (appname) {
  tor_snprintf(buf+n, sizeof(buf)-n,
               "%s opening %slog file.\n", appname, is_new?"new ":"");
} else {
  tor_snprintf(buf+n, sizeof(buf)-n,
               "Tor %s opening %slog file.\n", VERSION, is_new?"new ":"");
}

A quick grep for Tor %s and Tor v%s turned up

src/common/backtrace.c:220:  tor_asprintf(&bt_version, "Tor %s", tor_version);
src/common/log.c:259:                 "Tor %s opening %slog file.\n", VERSION, is_new?"new ":"");
src/or/entrynodes.c:576:      tor_asprintf(&tor_ver, "Tor %s", ver);
src/or/main.c:2459:  tor_snprintf(progname, sizeof(progname), "Tor %s", get_version());
src/or/router.c:752:  log_notice(LD_GENERAL, "Your Tor %s identity key fingerprint is '%s %s'",
src/or/router.c:2284:  tor_snprintf(platform, len, "Tor %s on %s",
src/or/statefile.c:441:  tor_asprintf(&global_state->TorVersion, "Tor %s", get_version());

and

src/or/main.c:2521:    log_notice(LD_GENERAL, "Tor v%s %srunning on %s with Libevent %s, "

comment:3 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-final

comment:4 Changed 4 years ago by nickm

Keywords: 027-triaged-1-out added

Marking triaged-out items from first round of 0.2.7 triage.

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

Make all non-needs_review, non-needs_revision, 027-triaged-1-out items belong to 0.2.???

comment:6 Changed 4 years ago by nickm

Keywords: easy added
Severity: Normal

comment:7 Changed 4 years ago by nickm

Points: small

comment:8 Changed 3 years ago by Jigsaw52

Status: newneeds_review

Here is my fix: https://github.com/Jigsaw52/tor/commits/fix-15381

I removed the v from the only message that had it.

comment:9 Changed 3 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.9.x-final

volunteer patches should get reviewed; putting in 029

comment:10 Changed 3 years ago by nickm

Sure, seems fine. Merged.

comment:11 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

(Thanks!)

Note: See TracTickets for help on using tickets.