Opened 5 years ago

Closed 4 years ago

#15400 closed defect (implemented)

Disable assertions during coverage builds

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This helps us more accurately track our branch coverage

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by Sebastian

Status: newneeds_review

Branch coverage_builds in my repo

comment:2 Changed 5 years ago by Sebastian

updated branch to include chutney in this.

comment:3 Changed 5 years ago by cypherpunks

A possible improvement for the preprocessor definition of TOR_COVERAGE is to do it through an conditional AC_DEFINE in configure.ac. The definition is then placed in orconfig.h which includes a comment about its meaning and makes it available to anything that includes the header.

The same could be said for existing preprocessor definitions but that is outside the scope of this ticket.

comment:4 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

looks okay to me

Note: See TracTickets for help on using tickets.