Opened 5 years ago

Last modified 8 months ago

#15456 new defect

Prevent incremental updates from failing for Linux hackers

Reported by: mikeperry Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-update
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While working on Bug #13375, I realized that people who hack up their TBB startup scripts are going to download the full MAR update if the incremental tries to change one of the startup scripts that they have modified. This may end up being a waste of bandwidth, depending on how commonly we push updates to these scripts, and how common it is that users modify them.

Originally, I was going to try to sneak this in to 4.5a5, but I am now convinced that it is too risky for an uncertain amount of improvement.

We should instead keep an eye on how often Linux users tend to download the full TBB MAR as opposed to the incremental, and if we notice a spike for instances where we have updated these files, then we should perform this optimization.

We can start by counting the fraction of Linux users download the full MAR for 4.5a5 (where the start-tor-browser script did change) and compare that to the fraction of Linux users who downloaded the full MAR for 4.5a1-4 (where the start-tor-browser script did not change). If there is a huge difference, we can consider trying to deploy this change.

Child Tickets

Change History (8)

comment:1 Changed 5 years ago by mcs

Cc: brade mcs added

comment:2 Changed 5 years ago by mikeperry

Keywords: tbb-4.5-alpha added

comment:3 Changed 4 years ago by mikeperry

I created #15706 for the stats gathering piece of this.

comment:4 Changed 4 years ago by mikeperry

Keywords: tbb-4.5-alpha removed

This is not going to happen for 4.5-stable. We need more data.

comment:5 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201504 removed

comment:6 Changed 23 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:7 Changed 9 months ago by gk

Keywords: tbb-updater added

comment:8 Changed 8 months ago by gk

Keywords: tbb-update added; tbb-updater removed

Renaming keyword to make it a bit broader

Note: See TracTickets for help on using tickets.