Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#15542 closed enhancement (implemented)

Have --hash-password imply hush?

Reported by: atagar Owned by:
Priority: Very Low Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From #14742, output of 'tor --hash-password' is unnecessarily noisy. Trivial improvement would be for '--hash-password' to implicitly include '--hush'.

atagar@odin:~/Desktop/stem$ tor --hash-password foo
Feb 06 09:35:46.451 [notice] Tor v0.2.6.2-alpha-dev (git-518b0b3c5fefba24) running on Linux with Libevent 2.0.16-stable, OpenSSL 1.0.1 and Zlib 1.2.3.4.
Feb 06 09:35:46.451 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Feb 06 09:35:46.451 [notice] This version is not a stable Tor release. Expect more bugs than usual.
16:59BB327C197C7A4B60C2DABC2ED2A9BACA04E4C48D138EF942D7A1E75C

atagar@odin:~/Desktop/stem$ tor --hash-password foo --hush
16:C51947FB29F63FAB606357CFE214C4EC3927CE7086FC5E9C65A212D657

Child Tickets

Attachments (1)

0001-Make-hash-password-imply-hush-to-prevent-unnecessary.patch (1.4 KB) - added by cypherpunks 4 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 4 years ago by cypherpunks

Status: newneeds_review

A trivial patch for the trivial improvement :)

comment:2 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-final

If it's trivial I'm happy to have a look in 0.2.7

comment:3 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

merged it.

comment:4 Changed 4 years ago by cypherpunks

I see you added a changes file for this ticket. However, the patch already contained a changes files, so now there are two changes files (ticket15542 and 15542).

Note: See TracTickets for help on using tickets.