Opened 4 years ago

Last modified 2 years ago

#15557 new defect

Improve relaunch logic for failed rendezvous circuits

Reported by: asn Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, tor-client, prop224, prop224-extra
Cc: Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor: SponsorR-can

Description

When a hidden service fails its rendezvous circuits (maybe because it's too overworked, or maybe its guard is overwhelmed) it currently retries up to MAX_REND_FAILURES times (this used to be 8 but #11447 will change it to 1).

When the client notices the failure, it will also retry every 2 seconds or so, subject to normal circuit_expire_building() expiry.

In the future, to reduce the computational costs of hidden services, we could push the retry logic solely to the clients. At that point the client should ensure that the rendezvous circuit retries enough time to be correct.

Furthermore, currently, when the client notices a rend circ failure, it will establish a new rendezvous point and send a new INTRODUCE1 cell to the IP. Maybe this can be optimized, and have the client keep the same rendezvous point for a while and just send more introductions. After a few more failed introductions, the client should switch rendezvous point as well.

Child Tickets

Change History (12)

comment:1 Changed 4 years ago by dgoulet

Milestone: Tor: 0.2.7.x-finalTor: 0.2.???

comment:2 Changed 4 years ago by nickm

Keywords: SponsorU removed
Sponsor: SponsorU

Bulk-replace SponsorU keyword with SponsorU field.

comment:3 Changed 4 years ago by dgoulet

Keywords: SponsorR removed
Sponsor: SponsorUSponsorR

comment:4 Changed 4 years ago by dgoulet

Milestone: Tor: 0.2.???Tor: 0.2.8.x-final
Points: medium
Priority: normalminor

comment:5 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

It is impossible that we will fix all 277 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "new" and "reopened" tickets, looking for things to move to ???.

comment:6 Changed 3 years ago by dgoulet

Sponsor: SponsorRSponsorR-can

Move those from SponsorR to SponsorR-can.

comment:7 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:8 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:9 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:10 Changed 2 years ago by dgoulet

Keywords: tor-client prop224 added
Parent ID: #15463#17242
Points: medium3
Severity: Normal

Very relevant to prop224 client implementation. Re-parenting.

comment:11 Changed 2 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.2.x-final

comment:12 Changed 2 years ago by dgoulet

Keywords: prop224-extra added
Milestone: Tor: 0.3.2.x-finalTor: unspecified
Parent ID: #17242
Note: See TracTickets for help on using tickets.