Opened 5 years ago

Closed 5 years ago

#15591 closed defect (fixed)

src/test/ntor_ref.py client_part2() doesn't check AUTH matches server response

Reported by: joelanders Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Line 285:

    badness = my_auth != their_auth
    badness = bad_result(yx) + bad_result(bx)

    if badness:
        return None

Second line probably oughta be badness |= ....

Child Tickets

Change History (2)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.7.x-final
Owner: set to nickm
Status: newaccepted

comment:2 Changed 5 years ago by nickm

Resolution: fixed
Status: acceptedclosed

Seems to have been fixed in f9327848, thanks to a patch from joelanders.

Note: See TracTickets for help on using tickets.