Opened 4 years ago

Closed 4 years ago

#15604 closed defect (fixed)

ConnDirectionStatistics is not ignored on client-only mode

Reported by: rl1987 Owned by:
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: 026-backport
Cc: karsten, rl1987@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Statistics-related torrc options that collect data which makes sense only if Tor is working in some specific role (relay/bridge) are ignored if Tor is not working in that mode of operation. For example, CellStatistics is set to 0 if Tor instance is not acting as a relay. However, ConnDirectionStatistics is an exception and it should not be.

Child Tickets

Change History (8)

comment:1 Changed 4 years ago by arma

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

Thanks rl1987! I'm setting this to 0.2.7.x since we should do it -- I worry in particular about the edge case where a Tor client has this option on, and then switches to being a Tor relay, and reports numbers in its extrainfo desc from back when it was a client.

This isn't a big deal since "nobody should set that option anyway", but we should still fix it.

comment:3 Changed 4 years ago by rl1987

Status: newneeds_review

comment:4 Changed 4 years ago by rl1987

Cc: rl1987@… added

comment:5 Changed 4 years ago by nickm

Keywords: 026-backport added

code looks fine; needs a "bugfix on" thing in the changes file.

comment:6 Changed 4 years ago by nickm

squashed and merged!

comment:7 Changed 4 years ago by arma

I vote no backport for #15604: it's not a big deal, and nobody knows about it or uses it.

comment:8 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

ok by me.

Note: See TracTickets for help on using tickets.