Opened 4 years ago

Closed 4 years ago

#15670 closed enhancement (wontfix)

Update the update_responses script for the 4.5 soft launch

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201504R, tbb-4.5-alpha
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

To allow releasing a new stable version without advertising it in the updater, we need an option in the config.yml file to say that the version is up-to-date and does not need to be downgraded to the version currently advertised in the updater.

I am attaching to this ticket a patch to add the 'no_update_for' option to the config.yml file. If we want to do a soft launch for 4.5, we will need to add the following lines to config.yml:

no_update_for:
    release:
        - 4.5

Child Tickets

Attachments (1)

0001-Bug-15670-add-support-for-the-no_update_for-option-i.patch (1.1 KB) - added by boklm 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by boklm

Keywords: TorBrowserTeam201504R added; TorBrowserTeam201504 removed
Status: newneeds_review

comment:2 Changed 4 years ago by mcs

I think this looks OK. At the point in time we want people running 4.0.8 to upgrade to 4.5, we would just remove the "no_update_for" directive and regenerate the update responses files?

comment:3 Changed 4 years ago by gk

Keywords: tbb-4.5-alpha added

comment:4 in reply to:  2 ; Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to mcs:

I think this looks OK. At the point in time we want people running 4.0.8 to upgrade to 4.5, we would just remove the "no_update_for" directive and regenerate the update responses files?

That would be one option, yes. Applied to master in commit 7d7faa30b4443f0cc76474738a36fd3f45e875f4. Do we really think this were necessary if we would just avoid updating the update responses files in the first place and deliver the updated ones only when we want to allow updating with the built-in updater? There should be no issue with possible downgrades of 4.5 users to 4.0.8 in this case as the updater related code is comparing versions and does not install the update if the proposed update has a lower version number IIRC.

Last edited 4 years ago by gk (previous) (diff)

comment:5 in reply to:  4 ; Changed 4 years ago by mcs

Replying to gk:

That would be one option, yes. Applied to master in commit 7d7faa30b4443f0cc76474738a36fd3f45e875f4. Do we really think this were necessary if we would just avoid updating the update responses files in the first place and deliver the updated ones only when we want to allow updating with the built-in updater? There should be no issue with possible downgrades of 4.5 users to 4.0.8 in this case as the updater related code is comparing versions and does not install the update if the proposed update has a lower version number IIRC.

I forgot to respond to this... yes, there should not be any downgrade issues.

comment:6 in reply to:  5 Changed 4 years ago by gk

Resolution: fixed
Status: closedreopened

Replying to mcs:

Replying to gk:

That would be one option, yes. Applied to master in commit 7d7faa30b4443f0cc76474738a36fd3f45e875f4. Do we really think this were necessary if we would just avoid updating the update responses files in the first place and deliver the updated ones only when we want to allow updating with the built-in updater? There should be no issue with possible downgrades of 4.5 users to 4.0.8 in this case as the updater related code is comparing versions and does not install the update if the proposed update has a lower version number IIRC.

I forgot to respond to this... yes, there should not be any downgrade issues.

boklm: So what is the exact scenario then which makes the patch necessary? I seem to be missing something. If we can get away with the idea mentioned in comment:4 I think backing this patch out might be the cleanest approach saving us some work (we'd need to upload update response files just once instead of twice).

comment:7 Changed 4 years ago by gk

Status: reopenedneeds_information

comment:8 Changed 4 years ago by boklm

Yes, if the updater code checks that the proposed upgrade is not a downgrade, then we can just avoid updating the update response files, instead of using the "no_update_for" option added by this patch. So the patch is not necessary.

comment:9 Changed 4 years ago by gk

Resolution: wontfix
Status: needs_informationclosed

Ok. I've reverted it in commit 6fddec33ed9d3baf343f3848bc3d85553de6b03b for now to make the releasing not more complex as it already is.

Note: See TracTickets for help on using tickets.