Opened 4 years ago

Closed 4 years ago

#15741 closed defect (fixed)

start-tor-browser should not detach/disown by default

Reported by: weasel Owned by: mikeperry
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: TorBrowserTeam201504
Cc: mcs Actual Points:
Parent ID: #15747 Points:
Reviewer: Sponsor:

Description

[ tor-browser-linux64-4.5a5_en-US ]

weasel@defiant:~$ ssh webweasel@localhost -X 'cd ~/tbb/tor-browser_en-US/Browser &&  bash -x ./start-tor-browser '
+ complain_dialog_title='Tor Browser'
+ '[' xlocalhost:10.0 = x ']'
+ '[' x/bin/bash = x ']'
+ unset SESSION_MANAGER
++ id -u
+ '[' 1001 -eq 0 ']'
+ debug=0
+ show_usage=0
+ '[' 0 -ge 1 -a '(' x = x--debug -o x = x-debug ')' ']'
+ '[' 0 -ge 1 -a '(' x = x--help -o x = x-help ')' ']'
+ exec
+ exec

and no browser.

If I launch it with --debug, it starts.

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by weasel

Don't run firefox in the background and disown it.

comment:2 Changed 4 years ago by gk

Keywords: TorBrowserTeam201504 tbb-4.5-alpha added
Owner: changed from tbb-team to mikeperry
Status: newassigned

See: #15740 and #15739 which are mainly irritating.

comment:3 Changed 4 years ago by mcs

Cc: mcs added

comment:4 Changed 4 years ago by mikeperry

Hrm.. This case seems specific to the ssh X tunnel thingy you're doing here. While I would like to find some way to support that case (since I've heard rumors there are a lot of Linux people who use a local nested X server as a poor-man's X11 sandbox, and I suspect you're doing something similar here), I really do think that disowning is the sane way for TBB to behave by default, esp when invoked from the .desktop file.

Is there either some way we can delay the disown to make your ssh hax work? Or should we provide a --foreground option for you that doesn't puke debug info, but also doesn't disown?

comment:5 Changed 4 years ago by weasel

There is no .desktop file in here.

I could not disagree more about normal shell command behavior, though. Stuff that I call should not exit and keep running in the background.

Maybe the desktop thing should call a --detach or something if that's needed and actually good practice there - I wouldn't know.

comment:6 in reply to:  5 Changed 4 years ago by mcs

Replying to weasel:

Maybe the desktop thing should call a --detach or something if that's needed and actually good practice there - I wouldn't know.

I like the idea of changing the default behavior back to how it was prior to 4.5a5 and adding a --detach option. But --foreground would at least provide a way to not detach.

comment:7 Changed 4 years ago by mikeperry

Keywords: tbb-4.5-alpha removed
Parent ID: #15747

Ok, I will add a --detach option and make the desktop file use it.

comment:8 Changed 4 years ago by mikeperry

Summary: start-tor-browser does not start tor browser. --debug doesstart-tor-browser should not detach/disown by default

comment:9 Changed 4 years ago by mikeperry

Resolution: fixed
Status: assignedclosed

Fixed in parent.

Note: See TracTickets for help on using tickets.