Opened 5 years ago

Closed 5 years ago

#15747 closed defect (fixed)

Improve start-tor-browser argument handling on Linux

Reported by: mikeperry Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-4.5-alpha, TorBrowserTeam201504, MikePerry201504
Cc: weasel, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should allow more than one argument to be specified at the same time, and generally behave better when this happens (right now, we just pass those extra args to Firefox, which is not great).

I was going to do this after 4.5-stable, but weasel has a number of related complaints about our argument handling, so I might as well fix all of this in one go. I will add those as child tickets.

Child Tickets

TicketStatusOwnerSummaryComponent
#15739closedtbb-teamstart-tor-browser -v does not workApplications/Tor Browser
#15740closedtbb-teamstart-tor-browser -h does not workApplications/Tor Browser
#15741closedmikeperrystart-tor-browser should not detach/disown by defaultApplications/Tor Browser

Change History (9)

comment:1 Changed 5 years ago by mikeperry

Cc: weasel added
Status: newneeds_review

comment:2 Changed 5 years ago by mikeperry

Summary: Improve argument handling on LinuxImprove start-tor-browser argument handling on Linux

comment:4 Changed 5 years ago by mikeperry

Cc: gk added

comment:5 Changed 5 years ago by weasel

I have copied the script, and it seems to work just fine. Thanks a lot.

Looking at the script, I wonder why in the elif [ "$show_output" -eq 1 ]; then case you redirect stderr to stdout.

Also, there's the usual shell ickyness that some variable usess might want quoting, such as $logfile.

Cheers,

comment:6 Changed 5 years ago by mcs

I did not run the revised scripts, but the changes look OK to me. Hopefully between the two of you (mikeperry and weasel) you have tested all of the various code paths....

comment:7 in reply to:  6 Changed 5 years ago by mcs

Replying to mcs:

I did not run the revised scripts, but the changes look OK to me. Hopefully between the two of you (mikeperry and weasel) you have tested all of the various code paths....

OK, I tried running and using various combinations of options. weasel's comments seem relevant; certainly it would be an improvement to quote $logfile every time it is used (that's the only variable I found that is used without quotes that may cause trouble).

comment:8 Changed 5 years ago by mikeperry

Ok, I addressed weasel's comments, tested some more and pushed a couple more fixup commits for them. I then squashed everything down in https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/log/?h=bug15747-squashed, and merged that to master. Thanks for the quick feedback!

comment:9 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.