Improve start-tor-browser argument handling on Linux

We should allow more than one argument to be specified at the same time, and generally behave better when this happens (right now, we just pass those extra args to Firefox, which is not great).

I was going to do this after 4.5-stable, but weasel has a number of related complaints about our argument handling, so I might as well fix all of this in one go. I will add those as child tickets.

added MikePerry201504 TorBrowserTeam201504 component::applications/tor browser owner::tbb-team priority::medium resolution::fixed status::closed tbb-4.5-alpha type::defect labels

https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/commit/?h=bug15747&id=25dc380448597001e14d11d55d05c69d6718c005 should handle all child tickets.

weasel - you should be able to drop https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/plain/RelativeLink/start-tor-browser?h=bug15747&id=25dc380448597001e14d11d55d05c69d6718c005 and https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/plain/RelativeLink/start-tor-browser.desktop?h=bug15747&id=25dc380448597001e14d11d55d05c69d6718c005 into the Browser subdirectory of your current Linux 4.5a5 TBB and have it work. Please let me know soon if you have any other issues with this (code review would also be appreciated).

Trac:
Cc: N/A to weasel
Status: new to needs_review

Trac:
Summary: Improve argument handling on Linux to Improve start-tor-browser argument handling on Linux

Heh, and I already found a bug. There's a fixup commit now at https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/commit/?h=bug15747&id=49af65d471dec7c2cbca527918229b5e125d9c42.

You probably want these links to get that and any future fixups: https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/plain/RelativeLink/start-tor-browser?h=bug15747 and https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/tree/RelativeLink/start-tor-browser.desktop?h=bug15747

Again, those files should work if dropped into the Browser subdir of a 4.5a5 Linux TBB.

Trac:
Cc: weasel to weasel, gk

I have copied the script, and it seems to work just fine. Thanks a lot.

Looking at the script, I wonder why in the elif [ "$show_output" -eq 1 ]; then case you redirect stderr to stdout.

Also, there's the usual shell ickyness that some variable usess might want quoting, such as $logfile.

Cheers,

I did not run the revised scripts, but the changes look OK to me. Hopefully between the two of you (mikeperry and weasel) you have tested all of the various code paths....

Replying to mcs:

I did not run the revised scripts, but the changes look OK to me. Hopefully between the two of you (mikeperry and weasel) you have tested all of the various code paths....

OK, I tried running and using various combinations of options. weasel's comments seem relevant; certainly it would be an improvement to quote $logfile every time it is used (that's the only variable I found that is used without quotes that may cause trouble).

Ok, I addressed weasel's comments, tested some more and pushed a couple more fixup commits for them. I then squashed everything down in https://gitweb.torproject.org/user/mikeperry/tor-browser-bundle.git/log/?h=bug15747-squashed, and merged that to master. Thanks for the quick feedback!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#15747 (closed)